mirror of
https://github.com/facebookincubator/mvfst.git
synced 2025-11-09 10:00:57 +03:00
Summary: We've long seen issues where paced congestion controllers can't keep up with the sending rate at low RTTs. While we have one mitigation for this, it only works after the pacing timer has fired. This introduces a new behavior that effectively makes the write looper ACK clock some of the time. The way it works is that when we call updateWriteLooper, if we've already missed the next pacing wakeup or it is going to fire soon (within 1ms), we cancel it and do a write in this loop. This effectively gives us multiple opportunities to write each burst, e.g. after receiving an ACK. Reviewed By: kvtsoy Differential Revision: D45052984 fbshipit-source-id: 591b6f5f374f4886dffa1e9be78df02d17fcc27c
165 lines
4.1 KiB
C++
165 lines
4.1 KiB
C++
/*
|
|
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#include <quic/common/FunctionLooper.h>
|
|
|
|
#include <folly/ScopeGuard.h>
|
|
|
|
namespace quic {
|
|
using namespace std::chrono_literals;
|
|
|
|
FunctionLooper::FunctionLooper(
|
|
folly::EventBase* evb,
|
|
folly::Function<void()>&& func,
|
|
LooperType type)
|
|
: evb_(evb), func_(std::move(func)), type_(type) {}
|
|
|
|
void FunctionLooper::setPacingTimer(
|
|
TimerHighRes::SharedPtr pacingTimer) noexcept {
|
|
pacingTimer_ = std::move(pacingTimer);
|
|
}
|
|
|
|
bool FunctionLooper::hasPacingTimer() const noexcept {
|
|
return pacingTimer_ != nullptr;
|
|
}
|
|
|
|
void FunctionLooper::setPacingFunction(
|
|
folly::Function<std::chrono::microseconds()>&& pacingFunc) {
|
|
pacingFunc_ = std::move(pacingFunc);
|
|
}
|
|
|
|
void FunctionLooper::commonLoopBody() noexcept {
|
|
inLoopBody_ = true;
|
|
SCOPE_EXIT {
|
|
inLoopBody_ = false;
|
|
};
|
|
auto hasBeenRunning = running_;
|
|
func_();
|
|
// callback could cause us to stop ourselves.
|
|
// Someone could have also called run() in the callback.
|
|
VLOG(10) << __func__ << ": " << type_ << " hasBeenRunning=" << hasBeenRunning
|
|
<< " running_=" << running_;
|
|
if (!running_) {
|
|
return;
|
|
}
|
|
if (!schedulePacingTimeout()) {
|
|
evb_->runInLoop(this);
|
|
}
|
|
}
|
|
|
|
bool FunctionLooper::schedulePacingTimeout() noexcept {
|
|
if (pacingFunc_ && pacingTimer_ && !isScheduled()) {
|
|
auto timeUntilWrite = (*pacingFunc_)();
|
|
if (timeUntilWrite != 0us) {
|
|
nextPacingTime_ = Clock::now() + timeUntilWrite;
|
|
pacingTimer_->scheduleTimeout(this, timeUntilWrite);
|
|
return true;
|
|
}
|
|
}
|
|
return false;
|
|
}
|
|
|
|
void FunctionLooper::runLoopCallback() noexcept {
|
|
folly::DelayedDestruction::DestructorGuard dg(this);
|
|
commonLoopBody();
|
|
}
|
|
|
|
void FunctionLooper::run(bool thisIteration) noexcept {
|
|
VLOG(10) << __func__ << ": " << type_;
|
|
running_ = true;
|
|
// Caller can call run() in func_. But if we are in pacing mode, we should
|
|
// prevent such loop.
|
|
if (pacingTimer_ && inLoopBody_) {
|
|
VLOG(4) << __func__ << ": " << type_
|
|
<< " in loop body and using pacing - not rescheduling";
|
|
return;
|
|
}
|
|
if (isLoopCallbackScheduled() || (!fireLoopEarly_ && isScheduled())) {
|
|
VLOG(10) << __func__ << ": " << type_ << " already scheduled";
|
|
return;
|
|
}
|
|
// If we are pacing, we're about to write again, if it's close, just write
|
|
// now.
|
|
if (isScheduled()) {
|
|
auto n = Clock::now();
|
|
auto timeUntilWrite = nextPacingTime_ < n
|
|
? 0us
|
|
: std::chrono::duration_cast<std::chrono::milliseconds>(
|
|
nextPacingTime_ - n);
|
|
if (timeUntilWrite <= 1ms) {
|
|
cancelTimeout();
|
|
// The next loop is good enough
|
|
thisIteration = false;
|
|
} else {
|
|
return;
|
|
}
|
|
}
|
|
evb_->runInLoop(this, thisIteration);
|
|
}
|
|
|
|
void FunctionLooper::stop() noexcept {
|
|
VLOG(10) << __func__ << ": " << type_;
|
|
running_ = false;
|
|
cancelLoopCallback();
|
|
cancelTimeout();
|
|
}
|
|
|
|
bool FunctionLooper::isRunning() const {
|
|
return running_;
|
|
}
|
|
|
|
void FunctionLooper::attachEventBase(folly::EventBase* evb) {
|
|
VLOG(10) << __func__ << ": " << type_;
|
|
DCHECK(!evb_);
|
|
DCHECK(evb && evb->isInEventBaseThread());
|
|
evb_ = evb;
|
|
}
|
|
|
|
void FunctionLooper::detachEventBase() {
|
|
VLOG(10) << __func__ << ": " << type_;
|
|
DCHECK(evb_ && evb_->isInEventBaseThread());
|
|
stop();
|
|
cancelTimeout();
|
|
evb_ = nullptr;
|
|
}
|
|
|
|
void FunctionLooper::timeoutExpired() noexcept {
|
|
folly::DelayedDestruction::DestructorGuard dg(this);
|
|
commonLoopBody();
|
|
}
|
|
|
|
void FunctionLooper::callbackCanceled() noexcept {
|
|
return;
|
|
}
|
|
|
|
folly::Optional<std::chrono::microseconds>
|
|
FunctionLooper::getTimerTickInterval() noexcept {
|
|
if (pacingTimer_) {
|
|
return pacingTimer_->getTickInterval();
|
|
}
|
|
return folly::none;
|
|
}
|
|
|
|
std::ostream& operator<<(std::ostream& out, const LooperType& rhs) {
|
|
switch (rhs) {
|
|
case LooperType::ReadLooper:
|
|
out << "ReadLooper";
|
|
break;
|
|
case LooperType::PeekLooper:
|
|
out << "PeekLooper";
|
|
break;
|
|
case LooperType::WriteLooper:
|
|
out << "WriteLooper";
|
|
break;
|
|
default:
|
|
out << "unknown";
|
|
break;
|
|
}
|
|
return out;
|
|
}
|
|
} // namespace quic
|