mirror of
https://github.com/facebookincubator/mvfst.git
synced 2025-04-17 06:37:00 +03:00
5c28840e5f
Summary:
There are a handful of BUCK definitions using this obscure macro, but none of
them actually send this flag:
```
$ grep msvc_compiler_flags_override $(xbgs mvfst_cxx_library -l)
E0414 15:57:22.013214 168505 Singleton.cpp:255] Registering singleton after registrationComplete().
fbsource/fbcode/quic/defs.bzl: windows_msvc_compiler_flags_override = kwargs.pop("windows_msvc_compiler_flags_override", WINDOWS_MSVC_CXXFLAGS),
fbsource/xplat/quic/defs.bzl: windows_msvc_compiler_flags_override = kwargs.pop("windows_msvc_compiler_flags_override", WINDOWS_MSVC_CXXFLAGS),
```
so we can delete it here.
If they ever need to add MSVC-specific flags, rather than augment this I think it would make sense to move away from the `mvfst_cxx_library()` macro.
Reviewed By: jbeshay, kvtsoy
Differential Revision: D73000543
fbshipit-source-id: 05a255126f8a7d0d606824b77a8123b6029b489d