1
0
mirror of https://github.com/facebookincubator/mvfst.git synced 2025-11-09 10:00:57 +03:00
Commit Graph

29 Commits

Author SHA1 Message Date
Luca Niccolini
cf842aab47 cleanup some unused includes and using
Reviewed By: yangchi

Differential Revision: D16976466

fbshipit-source-id: c1fc2ee0795997f498ac7431542bbfbf1f0d2fb2
2019-08-24 02:03:39 -07:00
Bonnie Xu
db349541f2 Update qlog format to be more complete
Summary: Update qlog format to be more complete. Adding the summary section (with extra fields like title, description, etc). This diff is just to make the format more on par with Robin's schema.

Reviewed By: mjoras

Differential Revision: D16499808

fbshipit-source-id: 56cfbb95404f7e3c6638bffda18b53f7d83048a1
2019-07-30 12:48:57 -07:00
Bonnie Xu
3203074c41 Reduce number of padding frames
Summary: Reduce the number of padding frames that are generated, to decrease overall qlog size.

Reviewed By: sharma95

Differential Revision: D16533449

fbshipit-source-id: 68f9c48e265576bff098dfeee87e576e86a32330
2019-07-29 10:16:30 -07:00
Bonnie Xu
f72ab2cfd6 Implement HTTP3 event interface
Summary: Implement HTTP3 event interface for qlog.

Reviewed By: yangchi

Differential Revision: D16424215

fbshipit-source-id: 041cd0a999eea49fdf98218348bd2a62e467a0b0
2019-07-27 14:07:58 -07:00
Bonnie Xu
63a79f278b Implement metricUpdate interface
Summary: Implement metricUpdate interface as part of spec.

Reviewed By: mjoras

Differential Revision: D16447278

fbshipit-source-id: 662361f257a336066a9f7ffb4e31eea6012add3f
2019-07-25 22:49:24 -07:00
Bonnie Xu
ce7ff9c215 Implement packetAck interface
Summary: Implement packetAck interface as part of spec.

Reviewed By: sharma95

Differential Revision: D16422768

fbshipit-source-id: f053a3b89ec080603d6568e37ad9281cf4834186
2019-07-25 11:52:21 -07:00
Bonnie Xu
5d871f45e0 Implement packetBuffered interface
Summary: Implement packetBuffered interface, as part of spec.

Reviewed By: yangchi

Differential Revision: D16415617

fbshipit-source-id: ece8e9fcd05c3cb7b7c63f7d652ed8df4c1a355b
2019-07-25 11:52:19 -07:00
Bonnie Xu
ed6d61690f Implement transportStateUpdate interface
Summary: Implement transportStateUpdate interface as part of [spec](fburl.com/proxygen-qlog).

Reviewed By: yangchi

Differential Revision: D16294320

fbshipit-source-id: 74f024782fc17b4706791c468866567238fac278
2019-07-20 10:09:22 -07:00
Bonnie Xu
14203ac53f Implement packetsLost interface
Summary: Implement packetsLost interface, as part of [spec](fburl.com/proxygen-qlog).

Reviewed By: yangchi

Differential Revision: D16292615

fbshipit-source-id: 7d313df209ac18f1deec92e32f557b0a1e97415c
2019-07-18 12:45:03 -07:00
Bonnie Xu
c550969a81 Implement lossAlarm interface
Summary: Implement lossAlarm interface according to [spec](fburl.com/proxygen-qlog).

Reviewed By: yangchi

Differential Revision: D16285188

fbshipit-source-id: f588f92230a0f0d9bf5d5fa7ad5673583b49fc1b
2019-07-18 09:47:51 -07:00
Bonnie Xu
ded2044f39 Implement datagramReceived interface
Summary: Implement datagramReceived interface, as part of [spec](fburl.com/proxygen-qlog).

Reviewed By: sharma95

Differential Revision: D16270834

fbshipit-source-id: fc112600b7d72a3ffdbb3b88584b2e17ed9c1ce1
2019-07-17 22:49:59 -07:00
Bonnie Xu
65dea29c7c Implement packetDrop interface for Quic
Summary: Implement packetDrop interface for Quic, as part of [spec](fburl.com/qlog-schema).

Reviewed By: yangchi

Differential Revision: D16233099

fbshipit-source-id: cf1fb67cea6f2599a6960593eace8122475c3557
2019-07-17 10:24:47 -07:00
Bonnie Xu
fb54bd8f06 Implement AppIdleUpdate interface for Quic
Summary: Implement AppIdleUpdate interface for Quic, as part of [spec](fburl.com/qlog-schema).

Reviewed By: yangchi

Differential Revision: D16231072

fbshipit-source-id: 09a759ad06388b7e8322179fbb9368b0015ae5a0
2019-07-16 16:37:38 -07:00
Lin Huang
28e7b0d837 Resolve land conflict between dirsync and quic pacing
Reviewed By: yangchi, xubonnie

Differential Revision: D16281430

fbshipit-source-id: 4d10b9cf5880cfcc4bb1c946e4234cf80ab68a12
2019-07-16 09:49:49 -07:00
Lin Huang
b4baf99a14 Move xplat/quic from autosyncer to dirsync
Summary:
* remove quic from autosyncer
* set up dirsync for quic
* mirror source file for xplat/quic fbcode/quic

Reviewed By: JunqiWang

Differential Revision: D16254573

fbshipit-source-id: 24414d275de310b5d0cf6bb2702a203e5aed260c
2019-07-16 01:09:48 -07:00
Bonnie Xu
9e4052c375 Implement pacingMetricUpdate interface for Quic
Summary: Implement pacingMetricUpdate interface for Quic. See [spec](fburl.com/qlog-schema) for details.

Reviewed By: yangchi

Differential Revision: D16205933

fbshipit-source-id: 858e7227ff2e3fae55d9de410818b7afe99fb0a5
2019-07-15 21:58:20 -07:00
Bonnie Xu
486fb616f6 Add metricUpdate event to Quic
Summary: Add metricUpdate event to Quic, so it can be logged as part of qlog.

Reviewed By: yangchi

Differential Revision: D16190166

fbshipit-source-id: 193b343f568fece4ca6bb43fa44e374a1df76c84
2019-07-15 21:41:26 -07:00
Bonnie Xu
4b2b63248e Implement metricUpdate interface for Quic
Summary: Implement metricUpdate interface for Quic. See [spec](fburl.com/qlog-schema) for details.

Reviewed By: yangchi

Differential Revision: D16170779

fbshipit-source-id: 3c4121a953aa93b7de7485f99a78765da1302d6f
2019-07-12 10:09:24 -07:00
Bonnie Xu
a5e59690bd Implemented TransportSummaryEvent interface for QLogger
Summary: Implemented TransportSummaryEvent interface for QLogger. See [spec](fburl.com/qlog-schema) for details.

Reviewed By: mjoras

Differential Revision: D16115821

fbshipit-source-id: 92da0a75b3c53a9287c456bb34a066a105a0ded4
2019-07-12 09:28:45 -07:00
Bonnie Xu
fc6aa8b248 Implemented ConnectionCloseEvent interface for QLogger
Summary:
Implemented ConnectionCloseEvent interface for QLogger. As part of spec, [see here.](fburl.com/qlog-schema)

I intend to add this to ProxygenQLogger after [D15945914](https://our.intern.facebook.com/intern/diff/D15945914/) lands, and connect it to Quic in the next diff (ex. `qLogger->add...`).

Reviewed By: yangchi

Differential Revision: D16093813

fbshipit-source-id: 040be49f9c762eeb0439ae6cf22e2596987d8791
2019-07-09 00:10:12 -07:00
Bonnie Xu
c8fc46a7ff Rename add to addPacket
Summary: Rename `add` to `addPacket`, since `add` is an ambiguous function name, especially as we include more events.

Reviewed By: sharma95

Differential Revision: D16102141

fbshipit-source-id: 73196a5f1bcc681e3bb0a26fd9edaf34f59bf710
2019-07-08 03:34:33 -07:00
Bonnie Xu
e32ca912d7 Implement ProxygenQLogger interface
Summary:
Implement ProxygenQLogger interface
- This includes creating the derived class for Proxygen based on QLogge

Reviewed By: yangchi

Differential Revision: D15945914

fbshipit-source-id: dc590b1453d72c8252323c5edd2605324bc06c82
2019-07-02 19:07:56 -07:00
Bonnie Xu
55a5e9b43b Added dcid, scid, reference time to toDynamic output
Summary: Added dcid, scid, reference time to toDynamic output, for FileQLogger, [in accordance to QLog output](https://raw.githubusercontent.com/quiclog/internet-drafts/master/examples/draft-00/draft-00-basic_example.qlog).

Reviewed By: sharma95

Differential Revision: D16036483

fbshipit-source-id: 6f2cec9c8705c808ccca36926568635627898a5d
2019-07-02 12:37:32 -07:00
Bonnie Xu
a6606f2a52 Setup logging in Quic based on QLogger
Summary: Setup logging in Quic based on QLogger.

Reviewed By: mjoras

Differential Revision: D15818340

fbshipit-source-id: 553aaedc6043a7f079c597ef0647c5b91f3033df
2019-06-24 09:45:45 -07:00
Yang Chi
7548623843 Rename generate.*Packet.* functions in Quic test utils to create.*Packet.*
Summary:
There is already a createPacket util function in this file. Rename the
newly added generate* functions to make this consistent

Reviewed By: sharma95

Differential Revision: D15948954

fbshipit-source-id: 67e7addefc839226b98d81a3808d37519ce001af
2019-06-21 17:34:51 -07:00
Bonnie Xu
91963d1af4 Refactor QLogger to include derived QLogger classes depending on use case
Summary:
Refactor QLogger to include derived QLogger classes depending on use case.

The QLog output will differ depending on what is requesting a QLog.

`File QLogger`: This is connected to HQ, stores all of the events per connection, and then outputs them to a file.

Reviewed By: sharma95

Differential Revision: D15928447

fbshipit-source-id: b2cdcd4d6305585b0f4f0aa21a95d1398aa761a5
2019-06-20 19:00:55 -07:00
Bonnie Xu
141dffce6a Fix QLogger test
Summary:
Fixed failing QLogger test.

Addresses reports https://our.intern.facebook.com/intern/test/281474989481205?ref_report_id=1876540 and https://our.intern.facebook.com/intern/test/844424942913490?ref_report_id=1876793.

Reviewed By: mjoras

Differential Revision: D15877059

fbshipit-source-id: e071d4ce7f70ffbd0d021f4f0e3edca7bcc51228
2019-06-18 13:44:43 -07:00
Bonnie Xu
805029b648 Added functionality to construct toDynamic objects
Summary: Converting stored QLog events into a toDynamic object that aligns with QLog format.

Reviewed By: sharma95

Differential Revision: D15725495

fbshipit-source-id: 0721a2d6858cfd99e191e3dfdc5f25f544106c86
2019-06-17 19:29:43 -07:00
Bonnie Xu
1affb7e49d Interface for QLogger
Summary:
Interface for QLogger:
- Takes in a Quic packet (`VersionNegotiation`, `RegularQuicWritePacket`, `RegularQuicPacket`)
- Stores it in QLogger
  - each packet is an event
  - each frame becomes a log

Reviewed By: sharma95

Differential Revision: D15581299

fbshipit-source-id: dedf933f47e2e8769109aa1e45ff38c2bf013714
2019-06-14 11:48:34 -07:00