3 Commits

Author	SHA1	Message	Date
Brandon Schlinker	87d00ece35	Fix dependency loop and improve namings ... Summary: Fixing dependency loop introduced by D37799050 (96abc8160d) Running `autodeps` yields the following patch: ``` --- a/xplat/quic/state/TARGETS +++ b/xplat/quic/state/TARGETS @@ -43,8 +43,8 @@ exported_deps = [ "//folly:random", "//quic:constants", + "//quic/codec:codec", "//quic/codec:types", - "//quic/common:circular_deque", "//quic/common:interval_set", ], ) ``` If this patch is applied, there is a circular dependency loop between `//quic/codec:codec` and `//quic/state:ack_states` by way of `//quic/codec:types`; this loop was introduced by D37799050 (96abc8160d). Fixed by separating out headers files and targets. In parallel, renamed structures used for writing ACK frames (which were the reason this loop occurred) to make their role clear. Differential Revision: D42281359 fbshipit-source-id: 8514c99f3fe72ff1d942d7f303e4a209838c7623	2023-01-05 15:20:44 -08:00
Sharad Jaiswal (Eng)	96abc8160d	Codec changes to support ACK_RECEIVE_TIMESTAMPS ... Summary: Create a new ACK_RECEIVE_TIMESTAMPS frame, as outlined in https://www.ietf.org/archive/id/draft-smith-quic-receive-ts-00.html#name-ack_receive_timestamps-fram Reviewed By: mjoras Differential Revision: D37799050 fbshipit-source-id: 0157c7fa7c4e489bb310f7c9cd6c0c1877e4967f	2022-11-16 13:02:27 -08:00
Brandon Schlinker	8b83739e89	Add largestAckedPacket to AckEvent ... Summary: `largestAcked` is a field in the `AckFrame` defined in section 19.3 ("ACK Frames") of RFC9000. This diff adds it to the `AckFrame` as `largestAckedPacket` after renaming the existing field of the same name to `largestNewlyAckedPacket` in D34896383 Some changes to the ACK unit tests were made as part of this change to ensure we're tracking everything correctly. Reviewed By: mjoras Differential Revision: D34951525 fbshipit-source-id: c84262a24a93bc05c8c817c5e8d5da229d971e36	2022-03-28 23:26:30 -07:00