Summary:
This re-enables the experimental pacer for bbr2 and bbr_testing, and removes fireLoopEarly by default.
FireLoopEarly can still be enabled via a knob.
Reviewed By: ritengupta, kvtsoy
Differential Revision: D65919713
fbshipit-source-id: e5d08a807be091c11326e9705601bd9e6bf79991
Summary:
When using msvc and compiling quic with C++20 there's a weird issue that the Looper is initialized with the wrong callbacks.
I suspect that this is because the constructor was creating the lambda as part of the header file.
Moving the constructor code to the cpp file fixed the issue
Reviewed By: hanidamlaj, kvtsoy
Differential Revision: D65994029
fbshipit-source-id: 9c5f47b62d0e0c74b5bce05f926e437e6aa2a3ab
Summary:
There are many files in this diff, but the relevant ones are:
* quic/api/QuicSocket.h
* quic/api/QuicSocketLite.h
* quic/api/QuicTransportBase.h
* quic/api/QuicTransportBaseLite.cpp
* quic/observer/SocketObserverContainer.h
The purpose of this is to include the observer functionality within the Lite class. Ideally, we'd remove it from the Lite class, but that's going to require some more detailed changes to the interfaces we're using, because observers are used quite a lot within common code (for example, AckHandlers.cpp).
I'll make those changes some time after the QuicTransportBase split, as they're going to take a while.
Reviewed By: jbeshay, mjoras, kvtsoy
Differential Revision: D65685667
fbshipit-source-id: feb07bcf35d6af2e5c2b538ff463b01b67c6aff9
Summary: This is pretty much the same as D65605100, which was reverted due to a cycle detection ([link](https://fb.workplace.com/groups/mobile.sheriffs/posts/27342968238658432/?comment_id=27343054638649792)). It turns out that the issue was that I didn't run `xplat/cross_plat_devx/somerge_maps/compute_merge_maps.py`.
Reviewed By: jbeshay
Differential Revision: D65761171
fbshipit-source-id: fc852ec13e54ea6ea45b4fda6b4556a78f38fc7f
Summary:
Our main use case for this right now is on the client side. So don't waste time doing all the callbacks per packet.
Also make it so the read callbacks don't update the loopers and check for closed streams every packet, defer that to the upper layer. In practice this means that when both options are on, these callbacks (besides the read callbacks) / checks / looper updates only happen once per read event.
Reviewed By: kvtsoy
Differential Revision: D65037206
fbshipit-source-id: 71119c9d2d857fcde747ea68676375d44b52c82f
Summary:
Required for LLVM-19 upgrade.
This diff removes a variable that was set, but which was not used.
LLVM-19 has a warning `-Wunused-but-set-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused but set variables often indicate a programming mistake, but can also just be unnecessary cruft that harms readability and performance.
Removing this variable will not change how your code works, but the unused variable may indicate your code isn't working the way you thought it was. If you feel the diff needs changes before landing, **please commandeer** and make appropriate changes: there are hundreds of these and responding to them individually is challenging.
For questions/comments, contact r-barnes.
- If you approve of this diff, please use the "Accept & Ship" button :-)
Reviewed By: hanidamlaj
Differential Revision: D64996230
fbshipit-source-id: 027b82a7fbf82b550157f9e75fe42557463250ee
Summary: If the peer sends higher stream limits in the settings, these callbacks may be invoked before the app has a chance to set the connection callback.
Reviewed By: sharmafb
Differential Revision: D64214648
fbshipit-source-id: 6a8a9b8d4d9e02a2baad672d69a43ba61daba918
Summary:
I have need of these in the proxygen WebTransport implementation, and don't want the full dependency on QuicSocket.
Also refactored WriteCallback into StreamWriteCallback and ConnWriteCallback, leaving the original WriteCallback as both for now.
Reviewed By: hanidamlaj
Differential Revision: D63486821
fbshipit-source-id: 4b16ad871c4deac4e262c12835ad5c457e9240da
