Summary: We don't use it, and the OSS lib hasn't been updated in a while.
Reviewed By: mjoras
Differential Revision: D46707559
fbshipit-source-id: ec102a52183a736cfb1c0241600816a837062108
Summary:
* pull the same version used by getdeps
* actually build zstd (we were not entering the directory)
Reviewed By: jbeshay
Differential Revision: D38952608
fbshipit-source-id: 68763cf558e9cfd11873f51e50b93ff6f4d0cad3
Summary:
Right now ubuntu build fails on folly dependency on newer zstd lib than is provided by distro.
Adding setup_zstd to clone and build zstd, similar to other dependencies.
Reviewed By: lnicco
Differential Revision: D26692582
fbshipit-source-id: bd7514cbf3e40271b25658fc543e6dc3d3c8b2ee
Summary: to make local changes to dependencies after the first build
Reviewed By: mjoras
Differential Revision: D25377891
fbshipit-source-id: fe4c8621c3845debe36432229ac4658d9cfbddfe
Summary:
This diff implements running ccp as a thread within mvfst.
1. It adds `libstartccp`, which is a tiny rust library that provides an interface between multiple ccp algorithms (written in rust) and the calling code in mvfst (written in c++). It exposes a single function `ccp_run_forever`, which takes an algorithm and optional parameters, and then starts ccp using the correct algorithm. This function never returns, so it is intended to be called from a dedicated thread.
2. When ccp is enabled and a `ccpConfig` is provided, `QuicServer` simply calls `ccp_run_forever` its own thread, passing the `ccpConfig`, which specifies both the algorithm name and any optional parameters.
To add a new ccp algorithm:
1. Place the algorithm source code in its own folder here: `quic/congestion_control/third_party/ccp/[ALGORITHM]`
2. Add the algorithm to `quic/congestion_control/third_party/ccp/src.rs`:
(a) Add `extern crate [ALGORITHM];` at the top.
(b) Add `register_alg!([ALGORITHM]);` at the end of the `_start` function.
Reviewed By: udippant
Differential Revision: D21854346
fbshipit-source-id: 5b0718a90d560e9cbe6e616daea5e910e00e6aeb
Summary: Adds dependencies and build rules for building quic with CCP_ENABLED using CMake.
Reviewed By: udippant
Differential Revision: D22736839
fbshipit-source-id: a59ac2df89312ca264ee78b217c6ccd0fcb64f29
Summary:
mvfst and proxygen both depend on folly, which depends on fmt, which must be built from source. the current build scripts get fmt from master, which could include a breaking change. this diff instead checks out the current latest version (6.2.1) which is known to build successfully.
related discussion in comments: https://fb.workplace.com/groups/248214662741731/permalink/601467044083156/
Reviewed By: lnicco
Differential Revision: D22213809
fbshipit-source-id: cf5efd2bf2bc694a3c246db9666088962465d4e9
Summary:
This adds a -c option to the build helper that will use ccache to build everything.
Pull Request resolved: https://github.com/facebookincubator/mvfst/pull/107
Reviewed By: yangchi
Differential Revision: D20457572
Pulled By: mjoras
fbshipit-source-id: b8cf13c49a2040acf211b1f443539c440d99e6fc
Summary:
this is how we do dependencies
fixes#86
Reviewed By: mjoras
Differential Revision: D19742747
fbshipit-source-id: bf90e1e327216e0342cd87ccfd1736d9078c8c3e
Summary:
Quic OSS Readme file missed one dep. The build script is likely wrong
too. On both Ubuntu and WSL, libfmt-dev installed from apt-get is too old to
have fmt/core.h file. So i removed the apt-get install libfmt-dev thing.
Reviewed By: mjoras
Differential Revision: D18763548
fbshipit-source-id: 6a83644dc3d825d0e7fd7ebed1af0df1ff0551dd
Summary:
This adds an argument to skip installing the system dependencies. This is useful to a project I am working on which wraps `mvfst` and installs dependent system packages in its own way.
Pull Request resolved: https://github.com/facebookincubator/mvfst/pull/45
Reviewed By: yangchi
Differential Revision: D17553209
Pulled By: udippant
fbshipit-source-id: 427a1df562ba7b6f6962aa42fb6f4ea5636e8101
Summary:
After changing fizz to export test headers and lib, we do not need to pull in
fizz as an ExternalProject anymore. This simplifies and fixes a lot of build
issues
Reviewed By: yangchi
Differential Revision: D15930220
fbshipit-source-id: dcb01c46b8ade545047c20af2fc5245223afff99
Summary: fix for the unbound variable and include fizz header
Reviewed By: mjoras
Differential Revision: D15565195
fbshipit-source-id: 1b02955a2546d57da71cab40ad0ceccdf4cee577
Summary:
As a workaround for https://github.com/facebook/folly/issues/976, modify build_helper.sh to allow disabling jemalloc use by passing the appropriate argument to the cmake invocation on folly.
Pull Request resolved: https://github.com/facebookincubator/mvfst/pull/14
Reviewed By: mjoras
Differential Revision: D15521328
Pulled By: udippant
fbshipit-source-id: 75a5f5abd99fd50fa939d32da99153ede9d8804e
Summary:
I cloned this repo for the first time today and ran into a few problems building on MacOS Mojave 10.14.
Here's a small number of standalone fixes to the `build_helper.sh` script.
Pull Request resolved: https://github.com/facebookincubator/mvfst/pull/3
Reviewed By: lnicco
Differential Revision: D15212179
Pulled By: udippant
fbshipit-source-id: 86b5619954851654cc756d0b238c89896d7b42d1
Summary: Do not rely on downloading it via wget in `build_helper.sh`
Reviewed By: siyengar
Differential Revision: D15215226
fbshipit-source-id: aeef31b30964674d80346aa6a1480ce03fdf478d
