lib/mvfst
1
0
Fork 0
mirror of https://github.com/facebookincubator/mvfst.git synced 2025-08-06 22:22:38 +03:00
Code Activity

QuicEventBase

Browse Source 
Summary:
A wrapper for `folly::EventBase` to be used throughout mvfst library.
Right now it's simply a `using QuicEventBase = folly::EventBase` in the new `quic/common/Events.h`, so no functional changes.

The change to the wrapper usage is constrained to QuicTransportBase and the code around for now - basically excluding top level client and server code that is still using `folly::EventBase` directly.

Subsequent changes will introduce a proper wrapper implementation getting rid of `using QuicEventBase = folly::EventBase` in the new class.

Reviewed By: mjoras

Differential Revision: D44757549

fbshipit-source-id: 5a0dd120ec319a474452eaec64a27f660144acdf
This commit is contained in:
Konstantin Tsoy
2023-05-23 14:16:15 -07:00
committed by Facebook GitHub Bot
parent 1bb2f15a0b
commit fdedffa855
18 changed files with 43 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
quic/api/test/QuicTransportBaseTest.cpp
View File

@@ -568,7 +568,7 @@ class TestQuicTransport
class QuicTransportImplTest : public Test {
public:
void SetUp() override {
evb = std::make_unique<folly::EventBase>();
evb = std::make_unique<QuicEventBase>();
auto socket =
std::make_unique<NiceMock<folly::test::MockAsyncUDPSocket>>(evb.get());
socketPtr = socket.get();
@@ -601,7 +601,7 @@ class QuicTransportImplTest : public Test {
}
protected:
std::unique_ptr<folly::EventBase> evb;
std::unique_ptr<QuicEventBase> evb;
NiceMock<MockConnectionSetupCallback> connSetupCallback;
NiceMock<MockConnectionCallback> connCallback;
TestByteEventCallback byteEventCallback;
@@ -4111,7 +4111,7 @@ TEST_P(QuicTransportImplTestBase, ObserverDetachAndAttachEvb) {
// check the current event base and create a new one
EXPECT_EQ(evb.get(), transport->getEventBase());
folly::EventBase evb2;
QuicEventBase evb2;
// Detach the event base evb
EXPECT_CALL(*obs1, evbDetach(transport.get(), evb.get())).Times(0);