lib/mvfst
1
0
Fork 0
mirror of https://github.com/facebookincubator/mvfst.git synced 2026-01-06 03:41:10 +03:00
Code Activity

Save a couple copy of dynamics in QLog

Browse Source 
Summary: Two of them can be moved. Two of them can be saved with copy-elision.

Reviewed By: sharma95, xubonnie

Differential Revision: D15951005

fbshipit-source-id: ea8a4c59c06bdb7f2c571d27fdd6390ec276961b
This commit is contained in:
Yang Chi
2019-06-24 09:22:27 -07:00
committed by Facebook Github Bot
parent 67ea785e85
commit fcd7577ba8
1 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
quic/logging/QLoggerTypes.cpp
View File

@@ -179,8 +179,8 @@ folly::dynamic ReadAckFrameLog::toDynamic() const {
folly::dynamic ackRangeDynamic = folly::dynamic::array();
for (const auto& b : ackBlocks) {
folly::dynamic subArray = folly::dynamic::array(b.startPacket, b.endPacket);
ackRangeDynamic.push_back(subArray);
ackRangeDynamic.push_back(
folly::dynamic::array(b.startPacket, b.endPacket));
}
d["acked_ranges"] = ackRangeDynamic;
d["frame_type"] = toString(FrameType::ACK);
@@ -193,8 +193,7 @@ folly::dynamic WriteAckFrameLog::toDynamic() const {
folly::dynamic ackRangeDynamic = folly::dynamic::array();
for (auto it = ackBlocks.cbegin(); it != ackBlocks.cend(); ++it) {
folly::dynamic subArray = folly::dynamic::array(it->start, it->end);
ackRangeDynamic.push_back(subArray);
ackRangeDynamic.push_back(folly::dynamic::array(it->start, it->end));
}
d["acked_ranges"] = ackRangeDynamic;
d["frame_type"] = toString(FrameType::ACK);
@@ -232,7 +231,7 @@ folly::dynamic QLogPacketEvent::toDynamic() const {
"packet_number", packetNum);
data["packet_type"] = packetType;
d.push_back(data);
d.push_back(std::move(data));
return d;
}
@@ -245,7 +244,7 @@ folly::dynamic QLogVersionNegotiationEvent::toDynamic() const {
data["header"] = folly::dynamic::object("packet_size", packetSize);
data["packet_type"] = packetType;
d.push_back(data);
d.push_back(std::move(data));
return d;
}