lib/mvfst
1
0
Fork 0
mirror of https://github.com/facebookincubator/mvfst.git synced 2025-08-08 09:42:06 +03:00
Code Activity

folly::Optional missing type parameter in QuicTransportBaseTest

Browse Source 
Summary: Add missing type parameter to two instances of `folly::Optional` introduced in D21653651 (98e0e4dc5d). It seems to build fine without the type parameters using buck on a devserver, but fails using CMake on an ubuntu machine.

Reviewed By: udippant

Differential Revision: D22632231

fbshipit-source-id: dec8ad2e11ce90b59dec4d7a9b9e1139b8cc1f41
This commit is contained in:
Frank Cangialosi
2020-07-20 12:54:17 -07:00
committed by Facebook GitHub Bot
parent 63a238afb6
commit fb07eef043
1 changed files with 11 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
quic/api/test/QuicTransportBaseTest.cpp
View File

@@ -3426,7 +3426,12 @@ TEST_F(
const std::pair<QuicErrorCode, std::string> defaultError = std::make_pair( const std::pair<QuicErrorCode, std::string> defaultError = std::make_pair(
GenericApplicationErrorCode::NO_ERROR, GenericApplicationErrorCode::NO_ERROR,
toString(GenericApplicationErrorCode::NO_ERROR)); toString(GenericApplicationErrorCode::NO_ERROR));
EXPECT_CALL(*cb, close(transport.get(), folly::Optional(defaultError))); EXPECT_CALL(
*cb,
close(
transport.get(),
folly::Optional<std::pair<QuicErrorCode, std::string>>(
defaultError)));
transport->close(folly::none); transport->close(folly::none);
Mock::VerifyAndClearExpectations(cb.get()); Mock::VerifyAndClearExpectations(cb.get());
InSequence s; InSequence s;
@@ -3448,7 +3453,11 @@ TEST_F(
const auto testError = std::make_pair( const auto testError = std::make_pair(
QuicErrorCode(LocalErrorCode::CONNECTION_RESET), QuicErrorCode(LocalErrorCode::CONNECTION_RESET),
std::string("testError")); std::string("testError"));
EXPECT_CALL(*cb, close(transport.get(), folly::Optional(testError))); EXPECT_CALL(
*cb,
close(
transport.get(),
folly::Optional<std::pair<QuicErrorCode, std::string>>(testError)));
transport->close(testError); transport->close(testError);
Mock::VerifyAndClearExpectations(cb.get()); Mock::VerifyAndClearExpectations(cb.get());
InSequence s; InSequence s;