lib/mvfst
1
0
Fork 0
mirror of https://github.com/facebookincubator/mvfst.git synced 2025-08-09 20:42:44 +03:00
Code Activity

refactor calculatePacingRate function

Browse Source 
Summary:
No need to pass the minimal interval any more since everywhere we just
pass the transportSettings value. Just that inside the function directly

Reviewed By: mjoras

Differential Revision: D16773023

fbshipit-source-id: 22ada4f25d565e97e7fce27371a0e2240bbfe8c0
This commit is contained in:
Yang Chi
2019-08-19 09:11:23 -07:00
committed by Facebook Github Bot
parent a9305ebbe1
commit eb10f2e36d
6 changed files with 21 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
quic/congestion_control/test/CongestionControlFunctionsTest.cpp
View File

@@ -23,14 +23,16 @@ class CongestionControlFunctionsTest : public Test {};
TEST_F(CongestionControlFunctionsTest, CalculatePacingRate) {
QuicConnectionStateBase conn(QuicNodeType::Client);
conn.udpSendPacketLen = 1;
conn.transportSettings.pacingTimerTickInterval = 10ms;
std::chrono::microseconds rtt(1000 * 100);
auto result = calculatePacingRate(
conn, 50, conn.transportSettings.minCwndInMss, 10ms, rtt);
auto result =
calculatePacingRate(conn, 50, conn.transportSettings.minCwndInMss, rtt);
EXPECT_EQ(10ms, result.first);
EXPECT_EQ(5, result.second);
auto result2 = calculatePacingRate(
conn, 300, conn.transportSettings.minCwndInMss, 1ms, rtt);
conn.transportSettings.pacingTimerTickInterval = 1ms;
auto result2 =
calculatePacingRate(conn, 300, conn.transportSettings.minCwndInMss, rtt);
EXPECT_EQ(1ms, result2.first);
EXPECT_EQ(3, result2.second);
}
@@ -38,8 +40,9 @@ TEST_F(CongestionControlFunctionsTest, CalculatePacingRate) {
TEST_F(CongestionControlFunctionsTest, MinPacingRate) {
QuicConnectionStateBase conn(QuicNodeType::Client);
conn.udpSendPacketLen = 1;
conn.transportSettings.pacingTimerTickInterval = 1ms;
auto result = calculatePacingRate(
conn, 100, conn.transportSettings.minCwndInMss, 1ms, 100000us);
conn, 100, conn.transportSettings.minCwndInMss, 100000us);
EXPECT_EQ(1ms, result.first);
EXPECT_EQ(1, result.second);
}
@@ -47,8 +50,9 @@ TEST_F(CongestionControlFunctionsTest, MinPacingRate) {
TEST_F(CongestionControlFunctionsTest, SmallCwnd) {
QuicConnectionStateBase conn(QuicNodeType::Client);
conn.udpSendPacketLen = 1;
conn.transportSettings.pacingTimerTickInterval = 1ms;
auto result = calculatePacingRate(
conn, 10, conn.transportSettings.minCwndInMss, 1ms, 100000us);
conn, 10, conn.transportSettings.minCwndInMss, 100000us);
EXPECT_EQ(10ms, result.first);
EXPECT_EQ(1, result.second);
}
@@ -56,8 +60,9 @@ TEST_F(CongestionControlFunctionsTest, SmallCwnd) {
TEST_F(CongestionControlFunctionsTest, RttSmallerThanInterval) {
QuicConnectionStateBase conn(QuicNodeType::Client);
conn.udpSendPacketLen = 1;
auto result = calculatePacingRate(
conn, 10, conn.transportSettings.minCwndInMss, 10ms, 1ms);
conn.transportSettings.pacingTimerTickInterval = 10ms;
auto result =
calculatePacingRate(conn, 10, conn.transportSettings.minCwndInMss, 1ms);
EXPECT_EQ(std::chrono::milliseconds::zero(), result.first);
EXPECT_EQ(
conn.transportSettings.writeConnectionDataPacketsLimit, result.second);