lib/mvfst
1
0
Fork 0
mirror of https://github.com/facebookincubator/mvfst.git synced 2025-08-06 22:22:38 +03:00
Code Activity

Fix QuicTransportTest

Browse Source 
Summary: An unused folly timer fd keeps the event base active causing the tests to timeout. This fixes it.

Differential Revision: D52647419

fbshipit-source-id: 57e699e9b34c9fd6d86cb6e0cb1705066f09e1c9
This commit is contained in:
Joseph Beshay
2024-01-09 19:49:55 -08:00
committed by Facebook GitHub Bot
parent 697ab96ea6
commit e8eff25a13
1 changed files with 0 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
quic/api/test/QuicTransportTest.cpp
View File

@@ -67,8 +67,6 @@ class QuicTransportTest : public Test {
public: public:
QuicTransportTest() { QuicTransportTest() {
qEvb_ = std::make_shared<FollyQuicEventBase>(&evb_); qEvb_ = std::make_shared<FollyQuicEventBase>(&evb_);
qTimer_ = std::make_unique<HighResQuicTimer>(
&evb_, evb_.timer().getTickInterval());
} }
~QuicTransportTest() override = default; ~QuicTransportTest() override = default;
@@ -124,7 +122,6 @@ class QuicTransportTest : public Test {
protected: protected:
folly::EventBase evb_; folly::EventBase evb_;
std::shared_ptr<FollyQuicEventBase> qEvb_; std::shared_ptr<FollyQuicEventBase> qEvb_;
std::unique_ptr<HighResQuicTimer> qTimer_;
MockAsyncUDPSocket* socket_; MockAsyncUDPSocket* socket_;
NiceMock<MockConnectionSetupCallback> connSetupCallback_; NiceMock<MockConnectionSetupCallback> connSetupCallback_;
NiceMock<MockConnectionCallback> connCallback_; NiceMock<MockConnectionCallback> connCallback_;