From e8eff25a13f5c27196a27e88ead88f0bd9dcd8d9 Mon Sep 17 00:00:00 2001 From: Joseph Beshay Date: Tue, 9 Jan 2024 19:49:55 -0800 Subject: [PATCH] Fix QuicTransportTest Summary: An unused folly timer fd keeps the event base active causing the tests to timeout. This fixes it. Differential Revision: D52647419 fbshipit-source-id: 57e699e9b34c9fd6d86cb6e0cb1705066f09e1c9 --- quic/api/test/QuicTransportTest.cpp | 3 --- 1 file changed, 3 deletions(-) diff --git a/quic/api/test/QuicTransportTest.cpp b/quic/api/test/QuicTransportTest.cpp index 3cb289880..bc0b68a22 100644 --- a/quic/api/test/QuicTransportTest.cpp +++ b/quic/api/test/QuicTransportTest.cpp @@ -67,8 +67,6 @@ class QuicTransportTest : public Test { public: QuicTransportTest() { qEvb_ = std::make_shared(&evb_); - qTimer_ = std::make_unique( - &evb_, evb_.timer().getTickInterval()); } ~QuicTransportTest() override = default; @@ -124,7 +122,6 @@ class QuicTransportTest : public Test { protected: folly::EventBase evb_; std::shared_ptr qEvb_; - std::unique_ptr qTimer_; MockAsyncUDPSocket* socket_; NiceMock connSetupCallback_; NiceMock connCallback_;