From ddf49f4d26040d992c291fe6ee5c4fa765a68892 Mon Sep 17 00:00:00 2001 From: Yang Chi Date: Sun, 17 May 2020 09:55:20 -0700 Subject: [PATCH] Use MockAsyncUDPSocket for Quic inplace batch writer tests Summary: To make sure the writer maker function actually return the Inplace writer Reviewed By: lnicco Differential Revision: D21613419 fbshipit-source-id: da7e59b43785b13fd91cc1a737db87af7dfb1c8f --- quic/api/test/QuicBatchWriterTest.cpp | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/quic/api/test/QuicBatchWriterTest.cpp b/quic/api/test/QuicBatchWriterTest.cpp index 7acee2660..5d44a9928 100644 --- a/quic/api/test/QuicBatchWriterTest.cpp +++ b/quic/api/test/QuicBatchWriterTest.cpp @@ -351,9 +351,8 @@ TEST_P(QuicBatchWriterTest, TestBatchingSendmmsgGSOBatcBigSmallPacket) { TEST_P(QuicBatchWriterTest, InplaceWriterNeedsFlush) { bool useThreadLocal = GetParam(); folly::EventBase evb; - folly::AsyncUDPSocket sock(&evb); - sock.setReuseAddr(false); - sock.bind(folly::SocketAddress("127.0.0.1", 0)); + folly::test::MockAsyncUDPSocket sock(&evb); + EXPECT_CALL(sock, getGSO()).WillRepeatedly(Return(1)); uint32_t batchSize = 20; auto bufAccessor = std::make_unique(conn_.udpSendPacketLen * batchSize); @@ -379,9 +378,8 @@ TEST_P(QuicBatchWriterTest, InplaceWriterNeedsFlush) { TEST_P(QuicBatchWriterTest, InplaceWriterAppendLimit) { bool useThreadLocal = GetParam(); folly::EventBase evb; - folly::AsyncUDPSocket sock(&evb); - sock.setReuseAddr(false); - sock.bind(folly::SocketAddress("127.0.0.1", 0)); + folly::test::MockAsyncUDPSocket sock(&evb); + EXPECT_CALL(sock, getGSO()).WillRepeatedly(Return(1)); uint32_t batchSize = 20; auto bufAccessor = std::make_unique(conn_.udpSendPacketLen * batchSize); @@ -415,9 +413,8 @@ TEST_P(QuicBatchWriterTest, InplaceWriterAppendLimit) { TEST_P(QuicBatchWriterTest, InplaceWriterAppendSmaller) { bool useThreadLocal = GetParam(); folly::EventBase evb; - folly::AsyncUDPSocket sock(&evb); - sock.setReuseAddr(false); - sock.bind(folly::SocketAddress("127.0.0.1", 0)); + folly::test::MockAsyncUDPSocket sock(&evb); + EXPECT_CALL(sock, getGSO()).WillRepeatedly(Return(1)); uint32_t batchSize = 20; auto bufAccessor = std::make_unique(conn_.udpSendPacketLen * batchSize);