lib/mvfst
1
0
Fork 0
mirror of https://github.com/facebookincubator/mvfst.git synced 2025-11-27 03:41:14 +03:00
Code Activity

Set batch size to request group size

Browse Source 
Summary: As in title. The comment here was right all along. In practice this doesn't matter that much, but it matters significantly to synthetic performance tests like tperf.

Reviewed By: shodoco

Differential Revision: D46726195

fbshipit-source-id: fe22d12a7ac3a237a30b5d0d19cc9a0fd7a21e11
This commit is contained in:
Matt Joras
2023-06-14 10:23:07 -07:00
committed by Facebook GitHub Bot
parent beb0902410
commit dd357a0a4e
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
quic/dsr/backend/DSRPacketizer.cpp
View File

@@ -99,10 +99,8 @@ BufQuicBatchResult writePacketsGroup(
LOG(ERROR) << "Empty packetization request"; LOG(ERROR) << "Empty packetization request";
return {}; return {};
} }
// TODO: Why don't I just limit the batch size to reqGroup.size()? What can go
// wrong?
auto batchWriter = auto batchWriter =
BatchWriterPtr(new GSOPacketBatchWriter(kDefaultQuicMaxBatchSize)); BatchWriterPtr(new GSOPacketBatchWriter(reqGroup.requests.size()));
// This doesn't matter: // This doesn't matter:
IOBufQuicBatch ioBufBatch( IOBufQuicBatch ioBufBatch(
std::move(batchWriter), std::move(batchWriter),