lib/mvfst
1
0
Fork 0
mirror of https://github.com/facebookincubator/mvfst.git synced 2025-11-25 15:43:13 +03:00
Code Activity

Rename ackFrameMatchesRetransmitBuffer to streamFrameMatchesRetransmitBuffer

Browse Source 
Summary:
The function indeed compares a Stream frame to a buffer, not an Ack
frame to a buffer.

Reviewed By: sharma95

Differential Revision: D18000632

fbshipit-source-id: fbbc36378404f8f52a199114af48b9020d0569e8
This commit is contained in:
Yang Chi
2019-10-18 15:52:22 -07:00
committed by Facebook Github Bot
parent fc71487c81
commit dc27ebf05d
6 changed files with 36 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
quic/state/test/QuicStreamFunctionsTest.cpp
View File

@@ -1940,7 +1940,9 @@ TEST_F(QuicStreamFunctionsTest, AckCryptoStreamOffsetLengthMismatch) {
EXPECT_EQ(cryptoStream.retransmissionBuffer.size(), 1);
}
TEST_F(QuicStreamFunctionsTest, AckFrameMatchesRetransmitBufferFullyReliable) {
TEST_F(
QuicStreamFunctionsTest,
StreamFrameMatchesRetransmitBufferFullyReliable) {
conn.partialReliabilityEnabled = false;
StreamId id = 4;
QuicStreamState stream(id, conn);
@@ -1953,12 +1955,12 @@ TEST_F(QuicStreamFunctionsTest, AckFrameMatchesRetransmitBufferFullyReliable) {
0 /* offset */,
data->length() /* length */,
true /* eof */);
EXPECT_TRUE(ackFrameMatchesRetransmitBuffer(stream, ackFrame, buf));
EXPECT_TRUE(streamFrameMatchesRetransmitBuffer(stream, ackFrame, buf));
}
TEST_F(
QuicStreamFunctionsTest,
AckFrameMatchesRetransmitBufferPartiallyReliableNoSkip) {
StreamFrameMatchesRetransmitBufferPartiallyReliableNoSkip) {
conn.partialReliabilityEnabled = true;
StreamId id = 4;
QuicStreamState stream(id, conn);
@@ -1971,12 +1973,12 @@ TEST_F(
0 /* offset */,
data->length() /* length */,
true /* eof */);
EXPECT_TRUE(ackFrameMatchesRetransmitBuffer(stream, ackFrame, buf));
EXPECT_TRUE(streamFrameMatchesRetransmitBuffer(stream, ackFrame, buf));
}
TEST_F(
QuicStreamFunctionsTest,
AckFrameMatchesRetransmitBufferPartiallyReliableFullBufSkipped) {
StreamFrameMatchesRetransmitBufferPartiallyReliableFullBufSkipped) {
conn.partialReliabilityEnabled = true;
StreamId id = 4;
QuicStreamState stream(id, conn);
@@ -1989,12 +1991,12 @@ TEST_F(
0 /* offset */,
data->length() /* length */,
true /* eof */);
EXPECT_FALSE(ackFrameMatchesRetransmitBuffer(stream, ackFrame, buf));
EXPECT_FALSE(streamFrameMatchesRetransmitBuffer(stream, ackFrame, buf));
}
TEST_F(
QuicStreamFunctionsTest,
AckFrameMatchesRetransmitBufferPartiallyReliableHalfBufSkipped) {
StreamFrameMatchesRetransmitBufferPartiallyReliableHalfBufSkipped) {
conn.partialReliabilityEnabled = true;
StreamId id = 4;
QuicStreamState stream(id, conn);
@@ -2004,7 +2006,7 @@ TEST_F(
WriteStreamFrame ackFrame(
id /* streamId */, 0 /* offset */, 5 /* length */, true /* eof */);
EXPECT_TRUE(ackFrameMatchesRetransmitBuffer(stream, ackFrame, buf));
EXPECT_TRUE(streamFrameMatchesRetransmitBuffer(stream, ackFrame, buf));
}
} // namespace test
} // namespace quic