lib/mvfst
1
0
Fork 0
mirror of https://github.com/facebookincubator/mvfst.git synced 2025-11-27 03:41:14 +03:00
Code Activity

Rename ackFrameMatchesRetransmitBuffer to streamFrameMatchesRetransmitBuffer

Browse Source 
Summary:
The function indeed compares a Stream frame to a buffer, not an Ack
frame to a buffer.

Reviewed By: sharma95

Differential Revision: D18000632

fbshipit-source-id: fbbc36378404f8f52a199114af48b9020d0569e8
This commit is contained in:
Yang Chi
2019-10-18 15:52:22 -07:00
committed by Facebook Github Bot
parent fc71487c81
commit dc27ebf05d
6 changed files with 36 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
quic/codec/QuicPacketRebuilder.cpp
View File

@@ -244,7 +244,7 @@ Buf PacketRebuilder::cloneRetransmissionBuffer(
return buffer.offset < targetOffset;
});
if (iter != stream->retransmissionBuffer.end()) {
if (ackFrameMatchesRetransmitBuffer(*stream, frame, *iter)) {
if (streamFrameMatchesRetransmitBuffer(*stream, frame, *iter)) {
DCHECK(!frame.len || !iter->data.empty())
<< "WriteStreamFrame cloning: frame is not empty but StreamBuffer has"
<< " empty data. " << conn_;