1
0
mirror of https://github.com/facebookincubator/mvfst.git synced 2025-08-08 09:42:06 +03:00

Use WriteOptions instead of a single int to allow for txTime setting too

Summary: Use WriteOptions instead of a single int to allow for txTime setting too

Reviewed By: mjoras

Differential Revision: D48218906

fbshipit-source-id: 00a1d4905b54ec0614860f9cdd8b58c9d6e6ef9a
This commit is contained in:
Dan Melnic
2023-08-16 13:19:12 -07:00
committed by Facebook GitHub Bot
parent db728cd1a3
commit d47d381da9
5 changed files with 30 additions and 21 deletions

View File

@@ -4422,8 +4422,8 @@ TEST_F(QuicTransportFunctionsTest, WriteWithInplaceBuilderGSOMultiplePackets) {
.Times(1)
.WillOnce(Invoke([&](const folly::SocketAddress&,
const std::unique_ptr<folly::IOBuf>& sockBuf,
int gso) {
EXPECT_LE(gso, conn->udpSendPacketLen);
folly::AsyncUDPSocket::WriteOptions options) {
EXPECT_LE(options.gso, conn->udpSendPacketLen);
EXPECT_GT(bufPtr->length(), 0);
EXPECT_EQ(sockBuf.get(), bufPtr);
EXPECT_TRUE(folly::IOBufEqualTo()(*sockBuf, *bufPtr));
@@ -4467,8 +4467,8 @@ TEST_F(QuicTransportFunctionsTest, WriteProbingWithInplaceBuilder) {
.Times(1)
.WillOnce(Invoke([&](const folly::SocketAddress&,
const std::unique_ptr<folly::IOBuf>& sockBuf,
int gso) {
EXPECT_LE(gso, conn->udpSendPacketLen);
folly::AsyncUDPSocket::WriteOptions options) {
EXPECT_LE(options.gso, conn->udpSendPacketLen);
EXPECT_GE(
bufPtr->length(),
conn->udpSendPacketLen *
@@ -4523,9 +4523,9 @@ TEST_F(QuicTransportFunctionsTest, WriteProbingWithInplaceBuilder) {
.Times(1)
.WillOnce(Invoke([&](const folly::SocketAddress&,
const std::unique_ptr<folly::IOBuf>& buf,
int gso) {
folly::AsyncUDPSocket::WriteOptions options) {
EXPECT_FALSE(buf->isChained());
EXPECT_EQ(conn->udpSendPacketLen, gso);
EXPECT_EQ(conn->udpSendPacketLen, options.gso);
EXPECT_EQ(buf->length(), conn->udpSendPacketLen * 2);
return buf->length();
}));