1
0
mirror of https://github.com/facebookincubator/mvfst.git synced 2025-08-08 09:42:06 +03:00

cleanup addWritable

Summary:
All the functionality is a duplicated from `updateWritableStreams`.

Btw the only callsites were inside UT.

Reviewed By: kvtsoy

Differential Revision: D68351972

fbshipit-source-id: 7e17f38ffcffecea23a64f5d2d5c1dec7a8c43f5
This commit is contained in:
Paul Farcasanu
2025-01-22 11:31:02 -08:00
committed by Facebook GitHub Bot
parent 9a46de20a4
commit d0c124fe15
4 changed files with 2 additions and 34 deletions

View File

@@ -4829,7 +4829,6 @@ TEST_P(
stream->writeBuffer.append(std::move(dataBuf));
// Insert streamId into the list.
conn->streamManager->addWritable(*stream);
conn->streamManager->updateWritableStreams(*stream);
// Write looper is running.
@@ -4893,7 +4892,6 @@ TEST_P(
stream->writeBuffer.append(std::move(dataBuf));
// Insert streamId into the list.
conn->streamManager->addWritable(*stream);
conn->streamManager->updateWritableStreams(*stream);
// Write looper is stopped.
@@ -4929,7 +4927,6 @@ TEST_P(
stream->writeBuffer.append(std::move(dataBuf));
// Insert streamId into the list.
conn->streamManager->addWritable(*stream);
conn->streamManager->updateWritableStreams(*stream);
// Write looper is running.
@@ -4969,7 +4966,6 @@ TEST_P(
stream->writeBuffer.append(std::move(dataBuf));
// Insert streamId into the list.
conn->streamManager->addWritable(*stream);
conn->streamManager->updateWritableStreams(*stream);
// Write looper is running.
@@ -5038,7 +5034,6 @@ TEST_P(
conn->flowControlState.sumCurStreamBufferLen = testString.length();
// Insert streamId into the list.
conn->streamManager->addWritable(*stream);
conn->streamManager->updateWritableStreams(*stream);
// Mock arming the write callback
@@ -5108,7 +5103,6 @@ TEST_P(
stream->writeBuffer.append(std::move(dataBuf));
// Insert streamId into the list.
conn->streamManager->addWritable(*stream);
conn->streamManager->updateWritableStreams(*stream);
// Write looper is running.