lib/mvfst
1
0
Fork 0
mirror of https://github.com/facebookincubator/mvfst.git synced 2025-11-25 15:43:13 +03:00
Code Activity

Revert PMTU and size-enforced packet builder

Browse Source 
Differential Revision: D23283619

fbshipit-source-id: b7fe31871dad5711016234a2d10ae84edc4fd24c
This commit is contained in:
Luca Niccolini
2020-08-22 16:54:27 -07:00
committed by Facebook GitHub Bot
parent 918cc5786d
commit c47c3cf5c6
23 changed files with 47 additions and 328 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
quic/client/state/ClientStateMachine.cpp
View File

@@ -43,8 +43,6 @@ std::unique_ptr<QuicClientConnectionState> undoAllClientStateForRetry(
newConn->originalPeerAddress = conn->originalPeerAddress;
newConn->peerAddress = conn->peerAddress;
newConn->udpSendPacketLen = conn->udpSendPacketLen;
newConn->peerMaxPacketSize = conn->peerMaxPacketSize;
newConn->currentPMTU = conn->currentPMTU;
newConn->supportedVersions = conn->supportedVersions;
newConn->transportSettings = conn->transportSettings;
newConn->initialWriteCipher = std::move(conn->initialWriteCipher);
@@ -153,13 +151,12 @@ void processServerInitialParams(
}
conn.peerAckDelayExponent =
ackDelayExponent.value_or(kDefaultAckDelayExponent);
// TODO: udpSendPacketLen should also be limited by PMTU
if (conn.transportSettings.canIgnorePathMTU) {
if (*packetSize > kDefaultMaxUDPPayload) {
*packetSize = kDefaultUDPSendPacketLen;
}
updateUdpSendPacketLen(conn, *packetSize);
conn.udpSendPacketLen = *packetSize;
}
// Currently no-op for a client; it doesn't issue connection ids
@@ -238,7 +235,7 @@ void updateTransportParamsFromCachedEarlyParams(
const CachedServerTransportParameters& transportParams) {
conn.peerIdleTimeout = std::chrono::milliseconds(transportParams.idleTimeout);
if (conn.transportSettings.canIgnorePathMTU) {
updateUdpSendPacketLen(conn, transportParams.maxRecvPacketSize);
conn.udpSendPacketLen = transportParams.maxRecvPacketSize;
}
conn.flowControlState.peerAdvertisedMaxOffset =
transportParams.initialMaxData;