Check that transport is still open in maybeStopWriteLooperAndArmSocketWritableEvent();

Summary: We can throw in `writeSocketDataAndCatch()` and that would result in transport closure with drain (with drain keeping the socket alive), but the congestion controller would be reset in close: https://fburl.com/code/zxwfye5u and `maybeStopWriteLooperAndArmSocketWritableEvent()` trips over it later when executed in scope exit.

Reviewed By: mjoras

Differential Revision: D57728369

fbshipit-source-id: 51a4719ae97fab0e90e3ae093a3f56be5a096aff

quic/api/test/QuicTransportBaseTest.cpp

@@ -574,6 +574,14 @@ class TestQuicTransport
     QuicTransportBase::maybeStopWriteLooperAndArmSocketWritableEvent();
   }
 
+  void closeImpl(
+      folly::Optional<QuicError> error,
+      bool drainConnection = true,
+      bool sendCloseImmediately = true) {
+    QuicTransportBase::closeImpl(
+        std::move(error), drainConnection, sendCloseImmediately);
+  }
+
   void onSocketWritable() noexcept override {
     QuicTransportBase::onSocketWritable();
   }
@@ -4906,5 +4914,39 @@ TEST_P(
   transport.reset();
 }
 
+TEST_P(
+    QuicTransportImplTestBase,
+    TestMaybeStopWriteLooperAndArmSocketWritableEventOnClosedSocket) {
+  auto transportSettings = transport->getTransportSettings();
+  transportSettings.useSockWritableEvents = true;
+  transport->setTransportSettings(transportSettings);
+  transport->getConnectionState().streamManager->refreshTransportSettings(
+      transportSettings);
+
+  transport->transportConn->oneRttWriteCipher = test::createNoOpAead();
+
+  // Create a stream with outgoing data.
+  auto streamId = transport->createBidirectionalStream().value();
+  const auto& conn = transport->transportConn;
+  auto stream = transport->getStream(streamId);
+  stream->writeBuffer.append(IOBuf::copyBuffer("hello"));
+
+  // Insert streamId into the list.
+  conn->streamManager->addWritable(*stream);
+  conn->streamManager->updateWritableStreams(*stream);
+
+  // Write looper is running.
+  transport->writeLooper()->run(true /* thisIteration */);
+  EXPECT_TRUE(transport->writeLooper()->isRunning());
+
+  // Close the socket.
+  transport->closeImpl((QuicError(
+      QuicErrorCode(TransportErrorCode::INTERNAL_ERROR),
+      std::string("writeSocketDataAndCatch()  error"))));
+  transport->maybeStopWriteLooperAndArmSocketWritableEvent();
+
+  transport.reset();
+}
+
 } // namespace test
 } // namespace quic