lib/mvfst
1
0
Fork 0
mirror of https://github.com/facebookincubator/mvfst.git synced 2025-08-06 22:22:38 +03:00
Code Activity

Remove trailing _E from QUIC variant type

Browse Source 
Summary:
I think this should just work without the trailing `_E`. It was added
when we mixed up our own union based variant and boost::variant. Some compiler
flags didn't like that. Now we no longer have mixed up cases, this should be
fine

Reviewed By: lnicco

Differential Revision: D25589393

fbshipit-source-id: 6430dc20f8e81af0329d89e6990c16826da168b8
This commit is contained in:
Yang Chi
2020-12-16 18:01:40 -08:00
committed by Facebook GitHub Bot
parent c7379ee82c
commit c1223a2f78
33 changed files with 483 additions and 494 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
quic/api/test/QuicTransportFunctionsTest.cpp
View File

@@ -1461,7 +1461,7 @@ TEST_F(QuicTransportFunctionsTest, WriteBlockedFrameWhenBlocked) {
EXPECT_GT(conn->ackStates.appDataAckState.nextPacketNum, originalNextSeq);
auto blocked = *getFirstFrameInOutstandingPackets(
conn->outstandings.packets,
QuicWriteFrame::Type::StreamDataBlockedFrame_E)
QuicWriteFrame::Type::StreamDataBlockedFrame)
.asStreamDataBlockedFrame();
EXPECT_EQ(blocked.streamId, stream1->id);
@@ -2321,7 +2321,7 @@ TEST_F(QuicTransportFunctionsTest, ProbeWriteNewFunctionalFrames) {
EXPECT_EQ(2, conn->outstandings.packets.size());
EXPECT_EQ(1, conn->outstandings.packets[1].packet.frames.size());
EXPECT_EQ(
QuicWriteFrame::Type::MaxDataFrame_E,
QuicWriteFrame::Type::MaxDataFrame,
conn->outstandings.packets[1].packet.frames[0].type());
}