lib/mvfst
1
0
Fork 0
mirror of https://github.com/facebookincubator/mvfst.git synced 2025-08-08 09:42:06 +03:00
Code Activity

Make the important Observer callbacks configurable

Browse Source 
Summary:
Given the large number of callbacks that are being triggered from the Observer
this change makes it possible to enable through a simple config, just the
subset of callbacks that a consumer is interested in receiving.

Observer and Socket Lifecycle callbacks are enabled by default, they are not
configurable.

Reviewed By: bschlinker

Differential Revision: D25879382

fbshipit-source-id: abe79ed92e958ddc96475c347f8ec7204400cdfa
This commit is contained in:
Sridhar Srinivasan
2021-01-13 15:33:33 -08:00
committed by Facebook GitHub Bot
parent 53a29b86f9
commit bd1ed4b7c0
14 changed files with 144 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
quic/api/test/QuicTransportBaseTest.cpp
View File

@@ -3560,7 +3560,9 @@ TEST_F(QuicTransportImplTest, ObserverMultipleAttachDestroyTransport) {
}
TEST_F(QuicTransportImplTest, ObserverDetachAndAttachEvb) {
auto cb = std::make_unique<StrictMock<MockObserver>>();
Observer::Config config = {};
config.evbEvents = true;
auto cb = std::make_unique<StrictMock<MockObserver>>(config);
folly::EventBase evb2;
EXPECT_CALL(*cb, observerAttach(transport.get()));