lib/mvfst
1
0
Fork 0
mirror of https://github.com/facebookincubator/mvfst.git synced 2025-07-29 03:41:11 +03:00
Code Activity

Integrate RangeChain into write path of QUIC stack

Browse Source 
Summary: See title

Reviewed By: mjoras

Differential Revision: D58216871

fbshipit-source-id: 9afc08946a676ec967c998416a6470d4884af550
This commit is contained in:
Aman Sharma
2024-08-15 05:46:08 -07:00
committed by Facebook GitHub Bot
parent b23e5027ea
commit bc386475e5
40 changed files with 496 additions and 276 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
quic/api/QuicPacketScheduler.cpp
View File

@ -538,7 +538,7 @@ bool StreamFrameScheduler::writeStreamFrame(
uint64_t flowControlLen =
std::min(getSendStreamFlowControlBytesWire(stream), connWritableBytes);
uint64_t bufferLen = stream.writeBuffer.chainLength();
uint64_t bufferLen = stream.pendingWrites.chainLength();
// We should never write a FIN from the non-DSR scheduler for a DSR stream.
bool canWriteFin = stream.finalWriteOffset.has_value() &&
bufferLen <= flowControlLen && stream.writeBufMeta.offset == 0;
@ -555,7 +555,7 @@ bool StreamFrameScheduler::writeStreamFrame(
if (!dataLen) {
return false;
}
writeStreamFrameData(builder, stream.writeBuffer, *dataLen);
writeStreamFrameData(builder, stream.pendingWrites, *dataLen);
VLOG(4) << "Wrote stream frame stream=" << stream.id
<< " offset=" << stream.currentWriteOffset
<< " bytesWritten=" << *dataLen
@ -803,7 +803,7 @@ CryptoStreamScheduler::CryptoStreamScheduler(
bool CryptoStreamScheduler::writeCryptoData(PacketBuilderInterface& builder) {
bool cryptoDataWritten = false;
uint64_t writableData =
folly::to<uint64_t>(cryptoStream_.writeBuffer.chainLength());
folly::to<uint64_t>(cryptoStream_.pendingWrites.chainLength());
// We use the crypto scheduler to reschedule the retransmissions of the
// crypto streams so that we know that retransmissions of the crypto data
// will always take precedence over the crypto data.
@ -819,7 +819,7 @@ bool CryptoStreamScheduler::writeCryptoData(PacketBuilderInterface& builder) {
if (writableData != 0) {
auto res = writeCryptoFrame(
cryptoStream_.currentWriteOffset, cryptoStream_.writeBuffer, builder);
cryptoStream_.currentWriteOffset, cryptoStream_.pendingWrites, builder);
if (res) {
VLOG(4) << "Wrote crypto frame"
<< " offset=" << cryptoStream_.currentWriteOffset
@ -831,7 +831,7 @@ bool CryptoStreamScheduler::writeCryptoData(PacketBuilderInterface& builder) {
}
bool CryptoStreamScheduler::hasData() const {
return !cryptoStream_.writeBuffer.empty() ||
return !cryptoStream_.pendingWrites.empty() ||
!cryptoStream_.lossBuffer.empty();
}