lib/mvfst
1
0
Fork 0
mirror of https://github.com/facebookincubator/mvfst.git synced 2025-08-08 09:42:06 +03:00
Code Activity

Move retransmission buffer CHECK

Browse Source 
Summary: This is just in wrong place. There can be multiple frames per packet that we may be implicitly ACKing.

Reviewed By: lnicco

Differential Revision: D21493553

fbshipit-source-id: 89befab01c5a27d400089478717110bca8137d99
This commit is contained in:
Matt Joras
2020-05-09 23:24:41 -07:00
committed by Facebook GitHub Bot
parent be37725692
commit b7389426dc
2 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
quic/api/test/QuicTransportFunctionsTest.cpp
View File

@@ -636,12 +636,15 @@ TEST_F(QuicTransportFunctionsTest, TestImplicitAck) {
packet = buildEmptyPacket(*conn, PacketNumberSpace::Initial);
packet.packet.frames.push_back(
WriteCryptoFrame(data->length(), data->length()));
packet.packet.frames.push_back(
WriteCryptoFrame(data->length() * 2, data->length()));
initialStream->writeBuffer.append(data->clone());
initialStream->writeBuffer.append(data->clone());
updateConnection(
*conn, folly::none, packet.packet, TimePoint(), getEncodedSize(packet));
EXPECT_EQ(2, conn->outstandingHandshakePacketsCount);
EXPECT_EQ(2, conn->outstandingPackets.size());
EXPECT_EQ(2, initialStream->retransmissionBuffer.size());
EXPECT_EQ(3, initialStream->retransmissionBuffer.size());
EXPECT_TRUE(initialStream->writeBuffer.empty());
EXPECT_TRUE(initialStream->lossBuffer.empty());