lib/mvfst
1
0
Fork 0
mirror of https://github.com/facebookincubator/mvfst.git synced 2025-12-03 03:40:56 +03:00
Code Activity

Add reliable_stream_reset transport parameter

Browse Source 
Summary: This diff adds the reliable_stream_reset transport parameter to mvfst.

Reviewed By: hanidamlaj

Differential Revision: D65383676

fbshipit-source-id: cb2f6a1a90004ea489447b67ed3cfc12ca90b804
This commit is contained in:
Aman Sharma
2024-12-17 11:53:15 -08:00
committed by Facebook GitHub Bot
parent 61c3de4842
commit ae011587d5
12 changed files with 194 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
quic/client/state/ClientStateMachine.cpp
View File

@@ -151,6 +151,21 @@ void processServerInitialParams(
static_cast<TransportParameterId>(
TransportParameterId::knob_frames_supported),
serverParams.parameters);
auto reliableResetTpIter = findParameter(
serverParams.parameters,
static_cast<TransportParameterId>(
TransportParameterId::reliable_stream_reset));
if (reliableResetTpIter != serverParams.parameters.end()) {
if (!reliableResetTpIter->value->empty()) {
throw QuicTransportException(
"Reliable reset transport parameter must be empty",
TransportErrorCode::TRANSPORT_PARAMETER_ERROR);
}
conn.peerAdvertisedReliableStreamResetSupport = true;
} else {
conn.peerAdvertisedReliableStreamResetSupport = false;
}
if (conn.version == QuicVersion::QUIC_V1 ||
conn.version == QuicVersion::QUIC_V1_ALIAS ||
conn.version == QuicVersion::QUIC_V1_ALIAS2) {
@@ -284,7 +299,8 @@ void cacheServerInitialParams(
bool peerAdvertisedKnobFrameSupport,
bool peerAdvertisedAckReceiveTimestampsEnabled,
uint64_t peerAdvertisedMaxReceiveTimestampsPerAck,
uint64_t peerAdvertisedReceiveTimestampsExponent) {
uint64_t peerAdvertisedReceiveTimestampsExponent,
bool peerAdvertisedReliableStreamResetSupport) {
conn.serverInitialParamsSet_ = true;
conn.peerAdvertisedInitialMaxData = peerAdvertisedInitialMaxData;
conn.peerAdvertisedInitialMaxStreamDataBidiLocal =
@@ -297,6 +313,8 @@ void cacheServerInitialParams(
peerAdvertisedInitialMaxStreamsBidi;
conn.peerAdvertisedInitialMaxStreamsUni = peerAdvertisedInitialMaxStreamUni;
conn.peerAdvertisedKnobFrameSupport = peerAdvertisedKnobFrameSupport;
conn.peerAdvertisedReliableStreamResetSupport =
peerAdvertisedReliableStreamResetSupport;
if (peerAdvertisedAckReceiveTimestampsEnabled) {
conn.maybePeerAckReceiveTimestampsConfig.assign(
@@ -334,6 +352,8 @@ CachedServerTransportParameters getServerCachedTransportParameters(
transportParams.knobFrameSupport = conn.peerAdvertisedKnobFrameSupport;
transportParams.ackReceiveTimestampsEnabled =
conn.maybePeerAckReceiveTimestampsConfig.has_value();
transportParams.reliableStreamResetSupport =
conn.peerAdvertisedReliableStreamResetSupport;
if (conn.maybePeerAckReceiveTimestampsConfig) {
transportParams.maxReceiveTimestampsPerAck =
conn.maybePeerAckReceiveTimestampsConfig->maxReceiveTimestampsPerAck;
@@ -361,6 +381,8 @@ void updateTransportParamsFromCachedEarlyParams(
conn.streamManager->setMaxLocalUnidirectionalStreams(
transportParams.initialMaxStreamsUni);
conn.peerAdvertisedKnobFrameSupport = transportParams.knobFrameSupport;
conn.peerAdvertisedReliableStreamResetSupport =
transportParams.reliableStreamResetSupport;
if (transportParams.ackReceiveTimestampsEnabled) {
conn.maybePeerAckReceiveTimestampsConfig.assign(
{std::min(