lib/mvfst
1
0
Fork 0
mirror of https://github.com/facebookincubator/mvfst.git synced 2025-11-25 15:43:13 +03:00
Code Activity

Check for max streams id limits when decoding MAX_STREAMS frame

Browse Source 
Summary:
Checks that MaxStreamsId is in range during MaxStreamsFrame decode, otherwise throws exception.

Added tests for MaxStreamsFrame decode.

Reviewed By: mjoras

Differential Revision: D27520634

fbshipit-source-id: f903763781639d078f92080b98f15b97e04a8d60
This commit is contained in:
Eric Christoffersen
2021-04-05 16:20:51 -07:00
committed by Facebook GitHub Bot
parent cfbf59202d
commit aac8f1ac91
2 changed files with 46 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
quic/codec/Decode.cpp
View File

@@ -449,7 +449,7 @@ MaxStreamDataFrame decodeMaxStreamDataFrame(folly::io::Cursor& cursor) {
MaxStreamsFrame decodeBiDiMaxStreamsFrame(folly::io::Cursor& cursor) {
auto streamCount = decodeQuicInteger(cursor);
if (!streamCount) {
if (!streamCount || streamCount->first > kMaxMaxStreams) {
throw QuicTransportException(
"Invalid Bi-directional streamId",
quic::TransportErrorCode::FRAME_ENCODING_ERROR,
@@ -460,7 +460,7 @@ MaxStreamsFrame decodeBiDiMaxStreamsFrame(folly::io::Cursor& cursor) {
MaxStreamsFrame decodeUniMaxStreamsFrame(folly::io::Cursor& cursor) {
auto streamCount = decodeQuicInteger(cursor);
if (!streamCount) {
if (!streamCount || streamCount->first > kMaxMaxStreams) {
throw QuicTransportException(
"Invalid Uni-directional streamId",
quic::TransportErrorCode::FRAME_ENCODING_ERROR,