lib/mvfst
1
0
Fork 0
mirror of https://github.com/facebookincubator/mvfst.git synced 2025-11-24 04:01:07 +03:00
Code Activity

Make client use new stateless retry

Browse Source 
Summary: This makes the change for the client to use stateless retries

Reviewed By: mjoras

Differential Revision: D19657433

fbshipit-source-id: d4b34087d15e49153860a7833ed54e28c6cd6777
This commit is contained in:
Aman Sharma
2020-04-08 20:56:25 -07:00
committed by Facebook GitHub Bot
parent 65cd15ff4c
commit a84d2e5fcb
7 changed files with 108 additions and 151 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
quic/codec/Decode.cpp
View File

@@ -930,36 +930,22 @@ folly::Expected<ParsedLongHeader, TransportErrorCode> parseLongHeaderVariants(
folly::io::Cursor& cursor,
QuicNodeType nodeType) {
if (type == LongHeader::Types::Retry) {
if (!cursor.canAdvance(sizeof(uint8_t))) {
VLOG(5) << "Not enough bytes for ODCID length";
return folly::makeUnexpected(TransportErrorCode::FRAME_ENCODING_ERROR);
}
uint8_t originalDstConnIdLen = cursor.readBE<uint8_t>();
if (originalDstConnIdLen > kMaxConnectionIdSize) {
VLOG(5) << "originalDstConnIdLen > kMaxConnectionIdSize: "
<< originalDstConnIdLen;
return folly::makeUnexpected(TransportErrorCode::PROTOCOL_VIOLATION);
}
if (!cursor.canAdvance(originalDstConnIdLen)) {
VLOG(5) << "Not enough bytes for ODCID";
return folly::makeUnexpected(TransportErrorCode::FRAME_ENCODING_ERROR);
}
ConnectionId originalDstConnId(cursor, originalDstConnIdLen);
if (cursor.totalLength() == 0) {
// The integrity tag is kRetryIntegrityTagLen bytes in length, and the
// token must be at least one byte, so the remaining length must
// be > kRetryIntegrityTagLen.
if (cursor.totalLength() <= kRetryIntegrityTagLen) {
VLOG(5) << "Not enough bytes for retry token";
return folly::makeUnexpected(TransportErrorCode::FRAME_ENCODING_ERROR);
}
Buf token;
cursor.clone(token, cursor.totalLength());
cursor.clone(token, cursor.totalLength() - kRetryIntegrityTagLen);
return ParsedLongHeader(
LongHeader(
type,
std::move(parsedLongHeaderInvariant.invariant),
token ? token->moveToFbString().toStdString() : std::string(),
std::move(originalDstConnId)),
token ? token->moveToFbString().toStdString() : std::string()),
PacketLength(0, 0));
}