lib/mvfst
1
0
Fork 0
mirror of https://github.com/facebookincubator/mvfst.git synced 2025-11-09 10:00:57 +03:00
Code Activity

Add more fields to Qlog Transport Summary to track spurious retransmissions

Browse Source 
Summary:
Add three new fields to the qlog transport summary to help analyze spurious transmissions and how they are affected by using adaptive loss thresholds.

Sample transport summary with added fields:
```
          "transport_summary",
          {
            "current_conn_flow_control": 1068498609,
            "current_writable_bytes": 106330,
            "dsr_packet_count": 0,
            "final_packet_loss_reordering_threshold": 77,
            "final_packet_loss_time_reordering_threshold_dividend": 29,
            "quic_version": 4207849474,
            "sum_cur_stream_buffer_len": 0,
            "sum_cur_write_offset": 5243215,
            "sum_max_observed_offset": 67,
            "total_bytes_cloned": 0,
            "total_bytes_recvd": 38157,
            "total_bytes_retransmitted": 244982,
            "total_bytes_sent": 5605121,
            "total_crypto_data_recvd": 342,
            "total_crypto_data_written": 1548,
            "total_packets_spuriously_marked_lost": 203,
            "total_stream_bytes_cloned": 0,
            "used_zero_rtt": false
          }
```

Reviewed By: afrind, mjoras

Differential Revision: D33354583

fbshipit-source-id: 55d9880ef02f6914b74c1b6508863bea7807950b
This commit is contained in:
Joseph Beshay
2022-01-07 18:41:05 -08:00
committed by Facebook GitHub Bot
parent 688d0ed31e
commit a73eade468
6 changed files with 55 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
quic/logging/test/QLoggerTest.cpp
View File

@@ -112,6 +112,9 @@ TEST_F(QLoggerTest, TransportSummaryEvent) {
238,
22,
44,
45,
46,
47,
false,
QuicVersion::MVFST,
37});
@@ -131,6 +134,9 @@ TEST_F(QLoggerTest, TransportSummaryEvent) {
EXPECT_EQ(gotEvent->totalCryptoDataRecvd, 238);
EXPECT_EQ(gotEvent->currentWritableBytes, 22);
EXPECT_EQ(gotEvent->currentConnFlowControl, 44);
EXPECT_EQ(gotEvent->totalPacketsSpuriouslyMarkedLost, 45);
EXPECT_EQ(gotEvent->finalPacketLossReorderingThreshold, 46);
EXPECT_EQ(gotEvent->finalPacketLossTimeReorderingThreshDividend, 47);
EXPECT_EQ(gotEvent->usedZeroRtt, false);
EXPECT_EQ(gotEvent->dsrPacketCount, 37);
}
@@ -759,6 +765,9 @@ TEST_F(QLoggerTest, TransportSummaryFollyDynamic) {
"total_crypto_data_recvd": 10,
"current_writable_bytes": 11,
"current_conn_flow_control": 12,
"total_packets_spuriously_marked_lost": 13,
"final_packet_loss_reordering_threshold": 14,
"final_packet_loss_time_reordering_threshold_dividend": 15,
"used_zero_rtt": true,
"quic_version": 4207849474,
"dsr_packet_count": 37
@@ -768,7 +777,24 @@ TEST_F(QLoggerTest, TransportSummaryFollyDynamic) {
FileQLogger q(VantagePoint::Client);
q.addTransportSummary(
{1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, true, QuicVersion::MVFST, 37});
{1,
2,
3,
4,
5,
6,
7,
8,
9,
10,
11,
12,
13,
14,
15,
true,
QuicVersion::MVFST,
37});
folly::dynamic gotDynamic = q.toDynamic();
gotDynamic["traces"][0]["events"][0][0] = "0"; // hardcode reference time
folly::dynamic gotEvents = gotDynamic["traces"][0]["events"];