diff --git a/quic/api/QuicSocket.h b/quic/api/QuicSocket.h index 34db0e6f0..26cadacd7 100644 --- a/quic/api/QuicSocket.h +++ b/quic/api/QuicSocket.h @@ -69,9 +69,9 @@ class QuicSocket { * Callback for connection level events once connection is set up. * The name is temporary until we phase out the old monolithic callback. */ - class ConnectionCallbackNew { + class ConnectionCallback { public: - virtual ~ConnectionCallbackNew() = default; + virtual ~ConnectionCallback() = default; /** * Invoked when stream id's flow control state changes. This is an edge @@ -223,7 +223,7 @@ class QuicSocket { * Sets connection streams callback. This callback must be set after * connection set up is finished and is ready for streams processing. */ - virtual void setConnectionCallbackNew(ConnectionCallbackNew* callback) = 0; + virtual void setConnectionCallback(ConnectionCallback* callback) = 0; /** * Sets the functions that mvfst will invoke to validate early data params diff --git a/quic/api/QuicTransportBase.cpp b/quic/api/QuicTransportBase.cpp index aeceaf600..89468435b 100644 --- a/quic/api/QuicTransportBase.cpp +++ b/quic/api/QuicTransportBase.cpp @@ -2705,8 +2705,7 @@ void QuicTransportBase::setConnectionSetupCallback( connSetupCallback_ = callback; } -void QuicTransportBase::setConnectionCallbackNew( - ConnectionCallbackNew* callback) { +void QuicTransportBase::setConnectionCallback(ConnectionCallback* callback) { connCallback_ = callback; } diff --git a/quic/api/QuicTransportBase.h b/quic/api/QuicTransportBase.h index 6e3c01bb8..182be37d3 100644 --- a/quic/api/QuicTransportBase.h +++ b/quic/api/QuicTransportBase.h @@ -225,7 +225,7 @@ class QuicTransportBase : public QuicSocket, QuicStreamPrioritiesObserver { void setConnectionSetupCallback(ConnectionSetupCallback* callback) final; - void setConnectionCallbackNew(ConnectionCallbackNew* callback) final; + void setConnectionCallback(ConnectionCallback* callback) final; void setEarlyDataAppParamsFunctions( folly::Function&, const Buf&) @@ -866,7 +866,7 @@ class QuicTransportBase : public QuicSocket, QuicStreamPrioritiesObserver { std::atomic evb_; std::unique_ptr socket_; ConnectionSetupCallback* connSetupCallback_{nullptr}; - ConnectionCallbackNew* connCallback_{nullptr}; + ConnectionCallback* connCallback_{nullptr}; // A flag telling transport if the new onConnectionEnd(error) cb must be used. bool useConnectionEndWithErrorCallback_{false}; diff --git a/quic/api/test/MockQuicSocket.h b/quic/api/test/MockQuicSocket.h index 828514914..c00531509 100644 --- a/quic/api/test/MockQuicSocket.h +++ b/quic/api/test/MockQuicSocket.h @@ -20,7 +20,7 @@ class MockQuicSocket : public QuicSocket { MockQuicSocket( folly::EventBase* /*eventBase*/, ConnectionSetupCallback* setupCb, - ConnectionCallbackNew* connCb) + ConnectionCallback* connCb) : setupCb_(setupCb), connCb_(connCb) {} MOCK_CONST_METHOD0(good, bool()); @@ -109,7 +109,7 @@ class MockQuicSocket : public QuicSocket { ReadCallback*, folly::Optional err)); MOCK_METHOD1(setConnectionSetupCallback, void(ConnectionSetupCallback*)); - MOCK_METHOD1(setConnectionCallbackNew, void(ConnectionCallbackNew*)); + MOCK_METHOD1(setConnectionCallback, void(ConnectionCallback*)); void setEarlyDataAppParamsFunctions( folly::Function&, const Buf&) const> validator, @@ -292,7 +292,7 @@ class MockQuicSocket : public QuicSocket { MOCK_METHOD1(setCongestionControl, void(CongestionControlType)); ConnectionSetupCallback* setupCb_; - ConnectionCallbackNew* connCb_; + ConnectionCallback* connCb_; folly::Function&, const Buf&)> earlyDataAppParamsValidator_; diff --git a/quic/api/test/Mocks.h b/quic/api/test/Mocks.h index dfc9e7dcf..c7dcf5529 100644 --- a/quic/api/test/Mocks.h +++ b/quic/api/test/Mocks.h @@ -120,9 +120,9 @@ class MockConnectionSetupCallback : public QuicSocket::ConnectionSetupCallback { #endif }; -class MockConnectionCallbackNew : public QuicSocket::ConnectionCallbackNew { +class MockConnectionCallback : public QuicSocket::ConnectionCallback { public: - ~MockConnectionCallbackNew() override = default; + ~MockConnectionCallback() override = default; #if defined(MOCK_METHOD) MOCK_METHOD((void), onFlowControlUpdate, (StreamId), (noexcept)); @@ -240,7 +240,7 @@ class MockQuicTransport : public QuicServerTransport { folly::EventBase* evb, std::unique_ptr sock, ConnectionSetupCallback* connSetupCb, - ConnectionCallbackNew* connCb, + ConnectionCallback* connCb, std::shared_ptr ctx) : QuicServerTransport(evb, std::move(sock), connSetupCb, connCb, ctx) {} diff --git a/quic/api/test/QuicStreamAsyncTransportTest.cpp b/quic/api/test/QuicStreamAsyncTransportTest.cpp index b7f6c52b8..8495d45bf 100644 --- a/quic/api/test/QuicStreamAsyncTransportTest.cpp +++ b/quic/api/test/QuicStreamAsyncTransportTest.cpp @@ -158,7 +158,7 @@ class QuicStreamAsyncTransportTest : public Test { std::shared_ptr server_; folly::SocketAddress serverAddr_; NiceMock serverConnectionSetupCB_; - NiceMock serverConnectionCB_; + NiceMock serverConnectionCB_; std::shared_ptr serverSocket_; QuicStreamAsyncTransport::UniquePtr serverAsyncWrapper_; folly::test::MockWriteCallback serverWriteCB_; @@ -169,7 +169,7 @@ class QuicStreamAsyncTransportTest : public Test { folly::EventBase clientEvb_; std::thread clientEvbThread_; NiceMock clientConnectionSetupCB_; - NiceMock clientConnectionCB_; + NiceMock clientConnectionCB_; QuicStreamAsyncTransport::UniquePtr clientAsyncWrapper_; folly::Promise startPromise_; folly::test::MockWriteCallback clientWriteCB_; diff --git a/quic/api/test/QuicTransportBaseTest.cpp b/quic/api/test/QuicTransportBaseTest.cpp index f18122c88..546e15b25 100644 --- a/quic/api/test/QuicTransportBaseTest.cpp +++ b/quic/api/test/QuicTransportBaseTest.cpp @@ -199,10 +199,10 @@ class TestQuicTransport folly::EventBase* evb, std::unique_ptr socket, ConnectionSetupCallback* connSetupCb, - ConnectionCallbackNew* connCb) + ConnectionCallback* connCb) : QuicTransportBase(evb, std::move(socket)) { setConnectionSetupCallback(connSetupCb); - setConnectionCallbackNew(connCb); + setConnectionCallback(connCb); auto conn = std::make_unique( FizzServerQuicHandshakeContext::Builder().build()); conn->clientConnectionId = ConnectionId({10, 9, 8, 7}); @@ -533,7 +533,7 @@ class QuicTransportImplTest : public Test { protected: std::unique_ptr evb; NiceMock connSetupCallback; - NiceMock connCallback; + NiceMock connCallback; TestByteEventCallback byteEventCallback; std::shared_ptr transport; folly::test::MockAsyncUDPSocket* socketPtr; diff --git a/quic/api/test/QuicTransportTest.cpp b/quic/api/test/QuicTransportTest.cpp index 6ace78706..20f46c41f 100644 --- a/quic/api/test/QuicTransportTest.cpp +++ b/quic/api/test/QuicTransportTest.cpp @@ -115,7 +115,7 @@ class QuicTransportTest : public Test { folly::EventBase evb_; MockAsyncUDPSocket* socket_; NiceMock connSetupCallback_; - NiceMock connCallback_; + NiceMock connCallback_; NiceMock writeCallback_; MockAead* aead_; std::unique_ptr headerCipher_; diff --git a/quic/api/test/TestQuicTransport.h b/quic/api/test/TestQuicTransport.h index f45a13ea1..9ccd0715b 100644 --- a/quic/api/test/TestQuicTransport.h +++ b/quic/api/test/TestQuicTransport.h @@ -22,10 +22,10 @@ class TestQuicTransport folly::EventBase* evb, std::unique_ptr socket, ConnectionSetupCallback* connSetupCb, - ConnectionCallbackNew* connCb) + ConnectionCallback* connCb) : QuicTransportBase(evb, std::move(socket)) { setConnectionSetupCallback(connSetupCb); - setConnectionCallbackNew(connCb); + setConnectionCallback(connCb); conn_.reset(new QuicServerConnectionState( FizzServerQuicHandshakeContext::Builder().build())); conn_->clientConnectionId = ConnectionId({9, 8, 7, 6}); diff --git a/quic/client/QuicClientAsyncTransport.h b/quic/client/QuicClientAsyncTransport.h index 2ed40836b..2ef08a605 100644 --- a/quic/client/QuicClientAsyncTransport.h +++ b/quic/client/QuicClientAsyncTransport.h @@ -18,7 +18,7 @@ namespace quic { */ class QuicClientAsyncTransport : public QuicStreamAsyncTransport, public QuicSocket::ConnectionSetupCallback, - public QuicSocket::ConnectionCallbackNew { + public QuicSocket::ConnectionCallback { public: using UniquePtr = std::unique_ptr< QuicClientAsyncTransport, diff --git a/quic/client/QuicClientTransport.cpp b/quic/client/QuicClientTransport.cpp index 8394052d7..829e759ca 100644 --- a/quic/client/QuicClientTransport.cpp +++ b/quic/client/QuicClientTransport.cpp @@ -1522,7 +1522,7 @@ void QuicClientTransport:: void QuicClientTransport::start( ConnectionSetupCallback* connSetupCb, - ConnectionCallbackNew* connCb) { + ConnectionCallback* connCb) { if (happyEyeballsEnabled_) { // TODO Supply v4 delay amount from somewhere when we want to tune this startHappyEyeballs( @@ -1545,7 +1545,7 @@ void QuicClientTransport::start( } setConnectionSetupCallback(connSetupCb); - setConnectionCallbackNew(connCb); + setConnectionCallback(connCb); clientConn_->pendingOneRttData.reserve( conn_->transportSettings.maxPacketsToBuffer); diff --git a/quic/client/QuicClientTransport.h b/quic/client/QuicClientTransport.h index daab159b7..a7def907e 100644 --- a/quic/client/QuicClientTransport.h +++ b/quic/client/QuicClientTransport.h @@ -97,7 +97,7 @@ class QuicClientTransport */ virtual void start( ConnectionSetupCallback* connSetupCb, - ConnectionCallbackNew* connCb); + ConnectionCallback* connCb); /** * Returns whether or not TLS is resumed. diff --git a/quic/client/test/Mocks.h b/quic/client/test/Mocks.h index 2897b1e1a..d1125efd5 100644 --- a/quic/client/test/Mocks.h +++ b/quic/client/test/Mocks.h @@ -95,7 +95,7 @@ class MockQuicClientTransport : public quic::QuicClientTransport { std::move(handshakeFactory)), testType_(testType) {} - void start(ConnectionSetupCallback* connSetupCb, ConnectionCallbackNew*) + void start(ConnectionSetupCallback* connSetupCb, ConnectionCallback*) override { auto cancelCode = QuicError( QuicErrorCode(LocalErrorCode::NO_ERROR), diff --git a/quic/fizz/client/test/QuicClientTransportTest.cpp b/quic/fizz/client/test/QuicClientTransportTest.cpp index a28734356..b781c63b5 100644 --- a/quic/fizz/client/test/QuicClientTransportTest.cpp +++ b/quic/fizz/client/test/QuicClientTransportTest.cpp @@ -244,7 +244,7 @@ class QuicClientTransportIntegrationTest : public TestWithParam { folly::EventBase eventbase_; folly::SocketAddress serverAddr; NiceMock clientConnSetupCallback; - NiceMock clientConnCallback; + NiceMock clientConnCallback; NiceMock readCb; std::shared_ptr client; std::shared_ptr serverCtx; @@ -1052,7 +1052,7 @@ TEST_F(QuicClientTransportTest, onNetworkSwitchReplaceNoHandshake) { TEST_F(QuicClientTransportTest, SocketClosedDuringOnTransportReady) { class ConnectionCallbackThatWritesOnTransportReady : public QuicSocket::ConnectionSetupCallback, - public QuicSocket::ConnectionCallbackNew { + public QuicSocket::ConnectionCallback { public: explicit ConnectionCallbackThatWritesOnTransportReady( std::shared_ptr socket) diff --git a/quic/fizz/client/test/QuicClientTransportTestUtil.h b/quic/fizz/client/test/QuicClientTransportTestUtil.h index 131ea08c1..d06b68f73 100644 --- a/quic/fizz/client/test/QuicClientTransportTestUtil.h +++ b/quic/fizz/client/test/QuicClientTransportTestUtil.h @@ -540,7 +540,7 @@ class QuicClientTransportTestBase : public virtual testing::Test { return clientConnSetupCallback; } - MockConnectionCallbackNew& getConnCallback() { + MockConnectionCallback& getConnCallback() { return clientConnCallback; } @@ -882,7 +882,7 @@ class QuicClientTransportTestBase : public virtual testing::Test { testing::NiceMock deliveryCallback; testing::NiceMock readCb; testing::NiceMock clientConnSetupCallback; - testing::NiceMock clientConnCallback; + testing::NiceMock clientConnCallback; folly::test::MockAsyncUDPSocket* sock; std::shared_ptr destructionCallback; diff --git a/quic/samples/echo/EchoClient.h b/quic/samples/echo/EchoClient.h index d57d3c459..4d860c64e 100644 --- a/quic/samples/echo/EchoClient.h +++ b/quic/samples/echo/EchoClient.h @@ -27,7 +27,7 @@ namespace quic { namespace samples { class EchoClient : public quic::QuicSocket::ConnectionSetupCallback, - public quic::QuicSocket::ConnectionCallbackNew, + public quic::QuicSocket::ConnectionCallback, public quic::QuicSocket::ReadCallback, public quic::QuicSocket::WriteCallback { public: diff --git a/quic/samples/echo/EchoHandler.h b/quic/samples/echo/EchoHandler.h index 78d89142d..e7d22007f 100644 --- a/quic/samples/echo/EchoHandler.h +++ b/quic/samples/echo/EchoHandler.h @@ -15,7 +15,7 @@ namespace quic { namespace samples { class EchoHandler : public quic::QuicSocket::ConnectionSetupCallback, - public quic::QuicSocket::ConnectionCallbackNew, + public quic::QuicSocket::ConnectionCallback, public quic::QuicSocket::ReadCallback, public quic::QuicSocket::WriteCallback { public: diff --git a/quic/server/QuicServerTransport.cpp b/quic/server/QuicServerTransport.cpp index f7312d0cf..24fe27fb6 100644 --- a/quic/server/QuicServerTransport.cpp +++ b/quic/server/QuicServerTransport.cpp @@ -24,7 +24,7 @@ QuicServerTransport::QuicServerTransport( folly::EventBase* evb, std::unique_ptr sock, ConnectionSetupCallback* connSetupCb, - ConnectionCallbackNew* connStreamsCb, + ConnectionCallback* connStreamsCb, std::shared_ptr ctx, std::unique_ptr cryptoFactory, PacketNum startingPacketNum) @@ -42,7 +42,7 @@ QuicServerTransport::QuicServerTransport( folly::EventBase* evb, std::unique_ptr sock, ConnectionSetupCallback* connSetupCb, - ConnectionCallbackNew* connStreamsCb, + ConnectionCallback* connStreamsCb, std::shared_ptr ctx, std::unique_ptr cryptoFactory, bool useConnectionEndWithErrorCallback) @@ -62,7 +62,7 @@ QuicServerTransport::QuicServerTransport( conn_->observers = observers_; setConnectionSetupCallback(connSetupCb); - setConnectionCallbackNew(connStreamsCb); + setConnectionCallback(connStreamsCb); registerAllTransportKnobParamHandlers(); } @@ -82,7 +82,7 @@ QuicServerTransport::Ptr QuicServerTransport::make( folly::EventBase* evb, std::unique_ptr sock, ConnectionSetupCallback* connSetupCb, - ConnectionCallbackNew* connStreamsCb, + ConnectionCallback* connStreamsCb, std::shared_ptr ctx, bool useConnectionEndWithErrorCallback) { return std::make_shared( diff --git a/quic/server/QuicServerTransport.h b/quic/server/QuicServerTransport.h index 8b9210875..45bafc5f5 100644 --- a/quic/server/QuicServerTransport.h +++ b/quic/server/QuicServerTransport.h @@ -62,7 +62,7 @@ class QuicServerTransport folly::EventBase* evb, std::unique_ptr sock, ConnectionSetupCallback* connSetupCb, - ConnectionCallbackNew* connStreamsCb, + ConnectionCallback* connStreamsCb, std::shared_ptr ctx, bool useConnectionEndWithErrorCallback = false); @@ -70,7 +70,7 @@ class QuicServerTransport folly::EventBase* evb, std::unique_ptr sock, ConnectionSetupCallback* connSetupCb, - ConnectionCallbackNew* connStreamsCb, + ConnectionCallback* connStreamsCb, std::shared_ptr ctx, std::unique_ptr cryptoFactory = nullptr, bool useConnectionEndWithErrorCallback = false); @@ -80,7 +80,7 @@ class QuicServerTransport folly::EventBase* evb, std::unique_ptr sock, ConnectionSetupCallback* connSetupCb, - ConnectionCallbackNew* connStreamsCb, + ConnectionCallback* connStreamsCb, std::shared_ptr ctx, std::unique_ptr cryptoFactory, PacketNum startingPacketNum); diff --git a/quic/server/async_tran/QuicServerAsyncTransport.h b/quic/server/async_tran/QuicServerAsyncTransport.h index 9ceb2e27e..bb2bd2138 100644 --- a/quic/server/async_tran/QuicServerAsyncTransport.h +++ b/quic/server/async_tran/QuicServerAsyncTransport.h @@ -13,7 +13,7 @@ namespace quic { class QuicServerAsyncTransport : public QuicStreamAsyncTransport, public QuicSocket::ConnectionSetupCallback, - public QuicSocket::ConnectionCallbackNew { + public QuicSocket::ConnectionCallback { public: using UniquePtr = std::unique_ptr< QuicServerAsyncTransport, diff --git a/quic/server/handshake/test/DefaultAppTokenValidatorTest.cpp b/quic/server/handshake/test/DefaultAppTokenValidatorTest.cpp index 96b4b9f7d..2e6a828fd 100644 --- a/quic/server/handshake/test/DefaultAppTokenValidatorTest.cpp +++ b/quic/server/handshake/test/DefaultAppTokenValidatorTest.cpp @@ -314,7 +314,7 @@ TEST(DefaultAppTokenValidatorTest, TestInvalidAppParams) { conn.statsCallback = quicStats.get(); MockConnectionSetupCallback connSetupCallback; - MockConnectionCallbackNew connCallback; + MockConnectionCallback connCallback; AppToken appToken; appToken.transportParams = createTicketTransportParameters( diff --git a/quic/server/test/QuicServerTest.cpp b/quic/server/test/QuicServerTest.cpp index 80f3efe0f..6eef1e3b4 100644 --- a/quic/server/test/QuicServerTest.cpp +++ b/quic/server/test/QuicServerTest.cpp @@ -72,7 +72,7 @@ TEST_F(SimpleQuicServerWorkerTest, RejectCid) { std::make_unique(&eventbase_); EXPECT_CALL(*mockSock, address()).WillRepeatedly(ReturnRef(addr)); MockConnectionSetupCallback mockConnectionSetupCallback; - MockConnectionCallbackNew mockConnectionCallback; + MockConnectionCallback mockConnectionCallback; MockQuicTransport::Ptr transportPtr = std::make_shared( &eventbase_, std::move(mockSock), @@ -170,7 +170,7 @@ class QuicServerWorkerTest : public Test { EXPECT_CALL(*socketFactory_, _make(_, _)).WillRepeatedly(Return(nullptr)); worker_->setNewConnectionSocketFactory(socketFactory_.get()); NiceMock connSetupCb; - NiceMock connCb; + NiceMock connCb; std::unique_ptr mockSock = std::make_unique>( &eventbase_); @@ -547,7 +547,7 @@ TEST_F(QuicServerWorkerTest, RateLimit) { EXPECT_CALL(*quicStats_, onConnectionRateLimited()).Times(1); NiceMock connSetupCb1; - NiceMock connCb1; + NiceMock connCb1; auto mockSock1 = std::make_unique>(&eventbase_); EXPECT_CALL(*mockSock1, address()).WillRepeatedly(ReturnRef(fakeAddress_)); @@ -584,7 +584,7 @@ TEST_F(QuicServerWorkerTest, RateLimit) { auto caddr2 = folly::SocketAddress("2.3.4.5", 1234); NiceMock connSetupCb2; - NiceMock connCb2; + NiceMock connCb2; auto mockSock2 = std::make_unique>(&eventbase_); EXPECT_CALL(*mockSock2, address()).WillRepeatedly(ReturnRef(caddr2)); @@ -643,7 +643,7 @@ TEST_F(QuicServerWorkerTest, UnfinishedHandshakeLimit) { EXPECT_CALL(*quicStats_, onConnectionRateLimited()).Times(1); NiceMock connSetupCb1; - NiceMock connCb1; + NiceMock connCb1; auto mockSock1 = std::make_unique>(&eventbase_); EXPECT_CALL(*mockSock1, address()).WillRepeatedly(ReturnRef(fakeAddress_)); @@ -679,7 +679,7 @@ TEST_F(QuicServerWorkerTest, UnfinishedHandshakeLimit) { auto caddr2 = folly::SocketAddress("2.3.4.5", 1234); NiceMock connSetupCb2; - NiceMock connCb2; + NiceMock connCb2; auto mockSock2 = std::make_unique>(&eventbase_); EXPECT_CALL(*mockSock2, address()).WillRepeatedly(ReturnRef(caddr2)); @@ -734,7 +734,7 @@ TEST_F(QuicServerWorkerTest, UnfinishedHandshakeLimit) { worker_->onHandshakeFinished(); auto caddr4 = folly::SocketAddress("4.3.4.5", 1234); NiceMock connSetupCb4; - NiceMock connCb4; + NiceMock connCb4; auto mockSock4 = std::make_unique>(&eventbase_); EXPECT_CALL(*mockSock4, address()).WillRepeatedly(ReturnRef(caddr4)); @@ -860,7 +860,7 @@ TEST_F(QuicServerWorkerTest, TestRetryInvalidInitialDstConnId) { TEST_F(QuicServerWorkerTest, QuicServerWorkerUnbindBeforeCidAvailable) { NiceMock connSetupCb; - NiceMock connCb; + NiceMock connCb; auto mockSock = std::make_unique>(&eventbase_); EXPECT_CALL(*mockSock, address()).WillRepeatedly(ReturnRef(fakeAddress_)); @@ -1041,7 +1041,7 @@ TEST_F(QuicServerWorkerTest, QuicServerNewConnection) { ConnectionId connId2({2, 4, 5, 6}); folly::SocketAddress clientAddr2("2.3.4.5", 2345); NiceMock connSetupCb; - NiceMock connCb; + NiceMock connCb; auto mockSock = std::make_unique>(&eventbase_); @@ -1430,7 +1430,7 @@ TEST_F(QuicServerWorkerTest, AcceptObserver) { auto initTestSocketAndTransport = [this]() { NiceMock connSetupCb; - NiceMock connCb; + NiceMock connCb; auto mockSock = std::make_unique>( &eventbase_); EXPECT_CALL(*mockSock, address()).WillRepeatedly(ReturnRef(fakeAddress_)); @@ -2092,7 +2092,7 @@ class QuicServerTest : public Test { std::shared_ptr transport; eventBase->runInEventBaseThreadAndWait([&] { NiceMock connSetupcb; - NiceMock connCb; + NiceMock connCb; std::unique_ptr mockSock = std::make_unique>( eventBase); @@ -2371,7 +2371,7 @@ class QuicServerTakeoverTest : public Test { folly::Baton<>& baton) { std::shared_ptr transport; NiceMock connSetupCb; - NiceMock connCb; + NiceMock connCb; auto makeTransport = [&](folly::EventBase* eventBase, std::unique_ptr& socket, @@ -2939,7 +2939,7 @@ TEST_F(QuicServerTest, ZeroRttPacketRoute) { setUpTransportFactoryForWorkers(evbs); std::shared_ptr transport; NiceMock connSetupCb; - NiceMock connCb; + NiceMock connCb; folly::Baton<> b; // create payload StreamId id = 1; @@ -3034,7 +3034,7 @@ TEST_F(QuicServerTest, ZeroRttBeforeInitial) { setUpTransportFactoryForWorkers(evbs); std::shared_ptr transport; NiceMock connSetupCb; - NiceMock connCb; + NiceMock connCb; folly::Baton<> b; // create payload StreamId id = 1; diff --git a/quic/server/test/QuicServerTransportTestUtil.h b/quic/server/test/QuicServerTransportTestUtil.h index 537e8bcf0..067c952cb 100644 --- a/quic/server/test/QuicServerTransportTestUtil.h +++ b/quic/server/test/QuicServerTransportTestUtil.h @@ -32,7 +32,7 @@ class TestingQuicServerTransport : public QuicServerTransport { folly::EventBase* evb, std::unique_ptr sock, ConnectionSetupCallback* connSetupCb, - ConnectionCallbackNew* connCb, + ConnectionCallback* connCb, std::shared_ptr ctx) : QuicServerTransport( evb, @@ -202,7 +202,7 @@ class QuicServerTransportTestBase : public virtual testing::Test { return connSetupCallback; } - MockConnectionCallbackNew& getConnCallback() { + MockConnectionCallback& getConnCallback() { return connCallback; } @@ -559,7 +559,7 @@ class QuicServerTransportTestBase : public virtual testing::Test { folly::SocketAddress serverAddr; folly::SocketAddress clientAddr; testing::NiceMock connSetupCallback; - testing::NiceMock connCallback; + testing::NiceMock connCallback; testing::NiceMock routingCallback; testing::NiceMock handshakeFinishedCallback; folly::Optional clientConnectionId; diff --git a/quic/tools/tperf/tperf.cpp b/quic/tools/tperf/tperf.cpp index f8dd48368..0ebfdd8be 100644 --- a/quic/tools/tperf/tperf.cpp +++ b/quic/tools/tperf/tperf.cpp @@ -231,7 +231,7 @@ class TPerfAcceptObserver : public AcceptObserver { } // namespace class ServerStreamHandler : public quic::QuicSocket::ConnectionSetupCallback, - public quic::QuicSocket::ConnectionCallbackNew, + public quic::QuicSocket::ConnectionCallback, public quic::QuicSocket::ReadCallback, public quic::QuicSocket::WriteCallback { public: @@ -568,7 +568,7 @@ class TPerfServer { }; class TPerfClient : public quic::QuicSocket::ConnectionSetupCallback, - public quic::QuicSocket::ConnectionCallbackNew, + public quic::QuicSocket::ConnectionCallback, public quic::QuicSocket::ReadCallback, public quic::QuicSocket::WriteCallback, public folly::HHWheelTimer::Callback {