From 94c254716dee29cd9de38a99ef1b27acdf1fe06a Mon Sep 17 00:00:00 2001 From: Konstantin Tsoy Date: Tue, 1 Aug 2023 19:31:34 -0700 Subject: [PATCH] Move a func to fix mvfst mobile build Summary: Broke in one of the previous commits. Reviewed By: hanidamlaj Differential Revision: D47962468 fbshipit-source-id: 532e9356cb7e1bba2e45ac0a18440a12aed1eb25 --- quic/api/QuicBatchWriter.cpp | 7 +++++++ quic/api/QuicBatchWriter.h | 4 ++++ quic/api/QuicBatchWriterFactory.cpp | 7 ------- quic/api/QuicBatchWriterFactory.h | 4 ---- 4 files changed, 11 insertions(+), 11 deletions(-) diff --git a/quic/api/QuicBatchWriter.cpp b/quic/api/QuicBatchWriter.cpp index 1d22cd4ce..392d60354 100644 --- a/quic/api/QuicBatchWriter.cpp +++ b/quic/api/QuicBatchWriter.cpp @@ -147,4 +147,11 @@ ssize_t SendmmsgPacketBatchWriter::write( return 0; } +bool useSinglePacketInplaceBatchWriter( + uint32_t maxBatchSize, + quic::DataPathType dataPathType) { + return maxBatchSize == 1 && + dataPathType == quic::DataPathType::ContinuousMemory; +} + } // namespace quic diff --git a/quic/api/QuicBatchWriter.h b/quic/api/QuicBatchWriter.h index 3ed04cc84..f9b920e8b 100644 --- a/quic/api/QuicBatchWriter.h +++ b/quic/api/QuicBatchWriter.h @@ -151,4 +151,8 @@ struct BatchWriterDeleter { }; using BatchWriterPtr = std::unique_ptr; + +bool useSinglePacketInplaceBatchWriter( + uint32_t maxBatchSize, + quic::DataPathType dataPathType); } // namespace quic diff --git a/quic/api/QuicBatchWriterFactory.cpp b/quic/api/QuicBatchWriterFactory.cpp index 165ae9453..dc86556a3 100644 --- a/quic/api/QuicBatchWriterFactory.cpp +++ b/quic/api/QuicBatchWriterFactory.cpp @@ -135,13 +135,6 @@ class ThreadLocalBatchWriterCache : public folly::AsyncTimeout { namespace quic { -bool useSinglePacketInplaceBatchWriter( - uint32_t maxBatchSize, - quic::DataPathType dataPathType) { - return maxBatchSize == 1 && - dataPathType == quic::DataPathType::ContinuousMemory; -} - // BatchWriterDeleter void BatchWriterDeleter::operator()(BatchWriter* batchWriter) { #if USE_THREAD_LOCAL_BATCH_WRITER diff --git a/quic/api/QuicBatchWriterFactory.h b/quic/api/QuicBatchWriterFactory.h index 6feef7cb9..5a230d42c 100644 --- a/quic/api/QuicBatchWriterFactory.h +++ b/quic/api/QuicBatchWriterFactory.h @@ -12,10 +12,6 @@ namespace quic { -bool useSinglePacketInplaceBatchWriter( - uint32_t maxBatchSize, - quic::DataPathType dataPathType); - BatchWriterPtr makeGsoBatchWriter(uint32_t batchSize); BatchWriterPtr makeGsoInPlaceBatchWriter( uint32_t batchSize,