lib/mvfst
1
0
Fork 0
mirror of https://github.com/facebookincubator/mvfst.git synced 2025-08-08 09:42:06 +03:00
Code Activity

Add onStreamPreReaped.

Browse Source 
Summary: This is potentially useful to an application to know when the underlying stream state has been freed by the transport.

Reviewed By: jbeshay

Differential Revision: D52048888

fbshipit-source-id: e7b2d33c3702ce8aa348459a37094198d16af60f
This commit is contained in:
Matt Joras
2023-12-13 10:08:47 -08:00
committed by Facebook GitHub Bot
parent 62af5ab602
commit 9285422f2a
4 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
quic/api/QuicSocket.h
View File

@@ -131,6 +131,12 @@ class QuicSocket {
StreamId, StreamId,
StreamGroupId) noexcept {} StreamGroupId) noexcept {}
/**
* Invoked when a given stream has been closed and its state reaped by
* the transport. After this point no operations can be done on the stream.
*/
virtual void onStreamStateReaped(StreamId) noexcept {}
/** /**
* Invoked when a stream receives a StopSending frame from a peer. * Invoked when a stream receives a StopSending frame from a peer.
* The application should reset the stream as part of this callback. * The application should reset the stream as part of this callback.

3
quic/api/QuicTransportBase.cpp
View File

@@ -2611,6 +2611,9 @@ void QuicTransportBase::checkForClosedStream() {
getClosingStream(folly::to<std::string>(*itr))); getClosingStream(folly::to<std::string>(*itr)));
} }
conn_->streamManager->removeClosedStream(*itr); conn_->streamManager->removeClosedStream(*itr);
if (connCallback_) {
connCallback_->onStreamStateReaped(*itr);
}
maybeSendStreamLimitUpdates(*conn_); maybeSendStreamLimitUpdates(*conn_);
if (readCbIt != readCallbacks_.end()) { if (readCbIt != readCallbacks_.end()) {
readCallbacks_.erase(readCbIt); readCallbacks_.erase(readCbIt);

1
quic/api/test/Mocks.h
View File

@@ -123,6 +123,7 @@ class MockConnectionCallback : public QuicSocket::ConnectionCallback {
onNewUnidirectionalStreamInGroup, onNewUnidirectionalStreamInGroup,
(StreamId, StreamGroupId), (StreamId, StreamGroupId),
(noexcept)); (noexcept));
MOCK_METHOD((void), onStreamStateReaped, (StreamId), (noexcept));
MOCK_METHOD( MOCK_METHOD(
(void), (void),
onStopSending, onStopSending,

1
quic/api/test/QuicTransportBaseTest.cpp
View File

@@ -1743,6 +1743,7 @@ TEST_P(QuicTransportImplTestBase, CloseStreamAfterReadError) {
transport->closeStream(stream1); transport->closeStream(stream1);
EXPECT_CALL(readCb1, readError(stream1, IsError(LocalErrorCode::NO_ERROR))); EXPECT_CALL(readCb1, readError(stream1, IsError(LocalErrorCode::NO_ERROR)));
EXPECT_CALL(connCallback, onStreamStateReaped(stream1));
transport->driveReadCallbacks(); transport->driveReadCallbacks();
EXPECT_FALSE(transport->transportConn->streamManager->streamExists(stream1)); EXPECT_FALSE(transport->transportConn->streamManager->streamExists(stream1));