lib/mvfst
1
0
Fork 0
mirror of https://github.com/facebookincubator/mvfst.git synced 2025-11-24 04:01:07 +03:00
Code Activity

remove setCustomTransportParameter helper function

Browse Source 
Summary:
- Remove setCustomTransportParameter, which (based on the quic v19 rfc), verifies whether a parameter is within the private range [0xff00, 0xffff]

> Values with the first byte in the range 0x00 to 0xfe (in hexadecimal) are assigned via the Specification Required policy [RFC8126].

- Consolidating adding MaxStreamGroups transport parameter into all other transport parameters extension.

More specifically, `QuicClientTransport::maybeEnableStreamGroups()` logic is now moved into `QuicClientTransport::setSupportedExtensionTransportParameters()`

Reviewed By: mjoras

Differential Revision: D50461610

fbshipit-source-id: 802b546c8364586cdcf36a230b156ca140c57ce4
This commit is contained in:
Hani Damlaj
2023-11-02 06:01:16 -07:00
committed by Facebook GitHub Bot
parent 1ded40bd8a
commit 905554ecd3
9 changed files with 11 additions and 100 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
quic/client/test/ClientStateMachineTest.cpp
View File

@@ -242,8 +242,7 @@ TEST_P(
CustomIntegralTransportParameter streamGroupsEnabledParam(
static_cast<uint64_t>(TransportParameterId::stream_groups_enabled),
GetParam().peerMaxGroupsIn);
CHECK(
setCustomTransportParameter(streamGroupsEnabledParam, transportParams));
transportParams.push_back(streamGroupsEnabledParam.encode());
}
ServerTransportParameters serverTransportParams = {
std::move(transportParams)};