lib/mvfst
1
0
Fork 0
mirror of https://github.com/facebookincubator/mvfst.git synced 2025-08-06 22:22:38 +03:00
Code Activity

remove setCustomTransportParameter helper function

Browse Source 
Summary:
- Remove setCustomTransportParameter, which (based on the quic v19 rfc), verifies whether a parameter is within the private range [0xff00, 0xffff]

> Values with the first byte in the range 0x00 to 0xfe (in hexadecimal) are assigned via the Specification Required policy [RFC8126].

- Consolidating adding MaxStreamGroups transport parameter into all other transport parameters extension.

More specifically, `QuicClientTransport::maybeEnableStreamGroups()` logic is now moved into `QuicClientTransport::setSupportedExtensionTransportParameters()`

Reviewed By: mjoras

Differential Revision: D50461610

fbshipit-source-id: 802b546c8364586cdcf36a230b156ca140c57ce4
This commit is contained in:
Hani Damlaj
2023-11-02 06:01:16 -07:00
committed by Facebook GitHub Bot
parent 1ded40bd8a
commit 905554ecd3
9 changed files with 11 additions and 100 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
quic/api/test/QuicTransportFunctionsTest.cpp
View File

@@ -4731,36 +4731,6 @@ TEST_F(QuicTransportFunctionsTest, MissingStreamFrameBytesSingleByteWrite) {
}
}
TEST_F(QuicTransportFunctionsTest, CustomTransportParamTest) {
std::vector<TransportParameter> customTransportParameters;
// Add new param.
EXPECT_TRUE(setCustomTransportParameter(
CustomIntegralTransportParameter(kCustomTransportParameterThreshold, 0),
customTransportParameters));
EXPECT_EQ(customTransportParameters.size(), 1);
// Existing param not added.
EXPECT_FALSE(setCustomTransportParameter(
CustomIntegralTransportParameter(kCustomTransportParameterThreshold, 1),
customTransportParameters));
EXPECT_EQ(customTransportParameters.size(), 1);
// Bad param id is not added.
EXPECT_FALSE(setCustomTransportParameter(
CustomIntegralTransportParameter(
kCustomTransportParameterThreshold - 1, 2),
customTransportParameters));
EXPECT_EQ(customTransportParameters.size(), 1);
// Another valid param added.
EXPECT_TRUE(setCustomTransportParameter(
CustomIntegralTransportParameter(
kCustomTransportParameterThreshold + 1, 0),
customTransportParameters));
EXPECT_EQ(customTransportParameters.size(), 2);
}
TEST_F(
QuicTransportFunctionsTest,
StaticCapOnWritableBytesFromThrottlingSignalProvider) {