lib/mvfst
1
0
Fork 0
mirror of https://github.com/facebookincubator/mvfst.git synced 2025-11-24 04:01:07 +03:00
Code Activity

Remove redundant const value kDefaultConnectionIdLimit

Browse Source 
Reviewed By: mjoras

Differential Revision: D22264684

fbshipit-source-id: aade83c4c19d0d285bd78755227bc257b071561a
This commit is contained in:
Junqi Wang
2020-06-29 15:51:20 -07:00
committed by Facebook GitHub Bot
parent 596c70c3ba
commit 8fd23f5316
4 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
quic/client/state/ClientStateMachine.cpp
View File

@@ -162,7 +162,7 @@ void processServerInitialParams(
// Currently no-op for a client; it doesn't issue connection ids // Currently no-op for a client; it doesn't issue connection ids
// to the server. // to the server.
conn.peerActiveConnectionIdLimit = conn.peerActiveConnectionIdLimit =
activeConnectionIdLimit.value_or(kDefaultConnectionIdLimit); activeConnectionIdLimit.value_or(kDefaultActiveConnectionIdLimit);
if (partialReliability && *partialReliability != 0 && if (partialReliability && *partialReliability != 0 &&
conn.transportSettings.partialReliabilityEnabled) { conn.transportSettings.partialReliabilityEnabled) {

1
quic/codec/QuicConnectionId.h
View File

@@ -33,7 +33,6 @@ constexpr size_t kMinInitialDestinationConnIdLength = 8;
// set conn id version at the first 4 bits // set conn id version at the first 4 bits
constexpr uint8_t kShortVersionId = 0x1; constexpr uint8_t kShortVersionId = 0x1;
constexpr uint64_t kDefaultConnectionIdLimit = 2;
constexpr uint64_t kInitialSequenceNumber = 0x0; constexpr uint64_t kInitialSequenceNumber = 0x0;
struct ConnectionId { struct ConnectionId {

2
quic/server/state/ServerStateMachine.cpp
View File

@@ -185,7 +185,7 @@ void processClientInitialParams(
} }
conn.peerActiveConnectionIdLimit = conn.peerActiveConnectionIdLimit =
activeConnectionIdLimit.value_or(kDefaultConnectionIdLimit); activeConnectionIdLimit.value_or(kDefaultActiveConnectionIdLimit);
if (partialReliability && *partialReliability != 0 && if (partialReliability && *partialReliability != 0 &&
conn.transportSettings.partialReliabilityEnabled) { conn.transportSettings.partialReliabilityEnabled) {

2
quic/state/TransportSettings.h
View File

@@ -155,7 +155,7 @@ struct TransportSettings {
// Default initial RTT // Default initial RTT
std::chrono::microseconds initialRtt{kDefaultInitialRtt}; std::chrono::microseconds initialRtt{kDefaultInitialRtt};
// The active_connection_id_limit that is sent to the peer. // The active_connection_id_limit that is sent to the peer.
uint64_t selfActiveConnectionIdLimit{kDefaultConnectionIdLimit}; uint64_t selfActiveConnectionIdLimit{kDefaultActiveConnectionIdLimit};
// Maximum size of the batch that should be used when receiving packets from // Maximum size of the batch that should be used when receiving packets from
// the kernel in one event loop. // the kernel in one event loop.
size_t maxRecvBatchSize{5}; size_t maxRecvBatchSize{5};