lib/mvfst
1
0
Fork 0
mirror of https://github.com/facebookincubator/mvfst.git synced 2025-11-24 04:01:07 +03:00
Code Activity

remove CustomTransportParameter

Browse Source 
Summary: deprecate CustomTransportParameter in favour of ::encodeIntegerParameter

Reviewed By: mjoras

Differential Revision: D50461613

fbshipit-source-id: 86ac95e6f871cef9cb819673387d65f5de42a0b8
This commit is contained in:
Hani Damlaj
2023-11-02 06:01:16 -07:00
committed by Facebook GitHub Bot
parent 905554ecd3
commit 8f742114d9
8 changed files with 57 additions and 125 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
quic/client/test/ClientStateMachineTest.cpp
View File

@@ -196,11 +196,8 @@ TEST_F(ClientStateMachineTest, TestProcessKnobFramesSupportedParamEnabled) {
QuicClientConnectionState clientConn(
FizzClientQuicHandshakeContext::Builder().build());
std::vector<TransportParameter> transportParams;
auto knobFrameSupportParam =
std::make_unique<CustomIntegralTransportParameter>(
static_cast<uint64_t>(TransportParameterId::knob_frames_supported),
1);
transportParams.push_back(knobFrameSupportParam->encode());
transportParams.push_back(
encodeIntegerParameter(TransportParameterId::knob_frames_supported, 1));
ServerTransportParameters serverTransportParams = {
std::move(transportParams)};
processServerInitialParams(clientConn, serverTransportParams, 0);
@@ -211,11 +208,8 @@ TEST_F(ClientStateMachineTest, TestProcessKnobFramesSupportedParamDisabled) {
QuicClientConnectionState clientConn(
FizzClientQuicHandshakeContext::Builder().build());
std::vector<TransportParameter> transportParams;
auto knobFrameSupportParam =
std::make_unique<CustomIntegralTransportParameter>(
static_cast<uint64_t>(TransportParameterId::knob_frames_supported),
0);
transportParams.push_back(knobFrameSupportParam->encode());
transportParams.push_back(
encodeIntegerParameter(TransportParameterId::knob_frames_supported, 0));
ServerTransportParameters serverTransportParams = {
std::move(transportParams)};
processServerInitialParams(clientConn, serverTransportParams, 0);
@@ -239,10 +233,9 @@ TEST_P(
std::vector<TransportParameter> transportParams;
if (GetParam().peerMaxGroupsIn > 0) {
CustomIntegralTransportParameter streamGroupsEnabledParam(
static_cast<uint64_t>(TransportParameterId::stream_groups_enabled),
GetParam().peerMaxGroupsIn);
transportParams.push_back(streamGroupsEnabledParam.encode());
transportParams.push_back(encodeIntegerParameter(
TransportParameterId::stream_groups_enabled,
GetParam().peerMaxGroupsIn));
}
ServerTransportParameters serverTransportParams = {
std::move(transportParams)};