lib/mvfst
1
0
Fork 0
mirror of https://github.com/facebookincubator/mvfst.git synced 2025-07-30 14:43:05 +03:00
Code Activity

Remove temporary setting for rejecting quic key updates

Browse Source 
Summary: This setting is no longer needed.

Reviewed By: mjoras

Differential Revision: D57112554

fbshipit-source-id: 4720dd864f24ac21a775419522254195c5ea215f
This commit is contained in:
Joseph Beshay
2024-05-09 18:08:14 -07:00
committed by Facebook GitHub Bot
parent 54c2913526
commit 8bfd2d1d66
2 changed files with 1 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
quic/api/QuicTransportFunctions.cpp
View File

@ -1946,10 +1946,6 @@ void updateOneRttWriteCipher(
void maybeHandleIncomingKeyUpdate(QuicConnectionStateBase& conn) { void maybeHandleIncomingKeyUpdate(QuicConnectionStateBase& conn) {
if (conn.readCodec->getCurrentOneRttReadPhase() != conn.oneRttWritePhase) { if (conn.readCodec->getCurrentOneRttReadPhase() != conn.oneRttWritePhase) {
// Peer has initiated a key update. // Peer has initiated a key update.
if (conn.transportSettings.rejectIncomingKeyUpdates) {
throw QuicTransportException(
"key update attempt rejected", TransportErrorCode::CRYPTO_ERROR);
}
updateOneRttWriteCipher( updateOneRttWriteCipher(
conn, conn,
conn.handshakeLayer->getNextOneRttWriteCipher(), conn.handshakeLayer->getNextOneRttWriteCipher(),

5
quic/state/TransportSettings.h
View File

@ -361,10 +361,7 @@ struct TransportSettings {
kFirstKeyUpdatePacketCount}; kFirstKeyUpdatePacketCount};
// How many packets to send before initiating periodic key updates // How many packets to send before initiating periodic key updates
uint64_t keyUpdatePacketCountInterval{kDefaultKeyUpdatePacketCountInterval}; uint64_t keyUpdatePacketCountInterval{kDefaultKeyUpdatePacketCountInterval};
// Whether to terminate the connection when a peer initiates a key update.
// TODO: Remove this. This is a temporary measure to gradually roll out key
// update support.
bool rejectIncomingKeyUpdates{false};
// Temporary flag to test new stream blocked condition. // Temporary flag to test new stream blocked condition.
bool useNewStreamBlockedCondition{false}; bool useNewStreamBlockedCondition{false};
bool scheduleTimerForExcessWrites{false}; bool scheduleTimerForExcessWrites{false};