From 8aff46c7c72c3e7739a778155fb9cbaa067eecb0 Mon Sep 17 00:00:00 2001 From: generatedunixname2419617681804656 Date: Mon, 6 Apr 2026 12:34:31 -0700 Subject: [PATCH] fbcode/quic/loss/test Reviewed By: jbeshay Differential Revision: D99422481 fbshipit-source-id: fb3b57cbbb401e14f74fa7b660d622ae86e03263 --- quic/loss/test/QuicLossFunctionsTest.cpp | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/quic/loss/test/QuicLossFunctionsTest.cpp b/quic/loss/test/QuicLossFunctionsTest.cpp index 668d42b31..57585832e 100644 --- a/quic/loss/test/QuicLossFunctionsTest.cpp +++ b/quic/loss/test/QuicLossFunctionsTest.cpp @@ -235,7 +235,7 @@ PacketNum QuicLossFunctionsTest::sendPacket( conn.ackStates.appDataAckState.nextPacketNum); break; } - PacketNumberSpace packetNumberSpace; + PacketNumberSpace packetNumberSpace{}; auto shortHeader = header->asShort(); if (shortHeader) { packetNumberSpace = shortHeader->getPacketNumberSpace(); @@ -1549,7 +1549,7 @@ TEST_F(QuicLossFunctionsTest, NoSkipLossVisitor) { return {}; }; // Send 5 packets, so when we ack the last one, we mark the first one loss - PacketNum lastSent; + PacketNum lastSent = 0; for (size_t i = 0; i < 5; i++) { lastSent = sendPacket(*conn, Clock::now(), std::nullopt, PacketType::OneRtt); @@ -1584,7 +1584,7 @@ TEST_F(QuicLossFunctionsTest, SkipLossVisitor) { return {}; }; // Send 5 packets, so when we ack the last one, we mark the first one loss - PacketNum lastSent; + PacketNum lastSent = 0; for (size_t i = 0; i < 5; i++) { lastSent = conn->ackStates.appDataAckState.nextPacketNum; ClonedPacketIdentifier clonedPacketIdentifier( @@ -1623,8 +1623,8 @@ TEST_F(QuicLossFunctionsTest, NoDoubleProcess) { }; // Send 6 packets, so when we ack the last one, we mark the first two loss EXPECT_EQ(1, conn->ackStates.appDataAckState.nextPacketNum); - PacketNum lastSent; - lastSent = sendPacket(*conn, Clock::now(), std::nullopt, PacketType::OneRtt); + PacketNum lastSent = + sendPacket(*conn, Clock::now(), std::nullopt, PacketType::OneRtt); EXPECT_EQ(1, conn->outstandings.packetCount[PacketNumberSpace::AppData]); ClonedPacketIdentifier clonedPacketIdentifier( PacketNumberSpace::AppData, lastSent);