lib/mvfst
1
0
Fork 0
mirror of https://github.com/facebookincubator/mvfst.git synced 2025-07-30 14:43:05 +03:00
Code Activity

Remove default priority param.

Browse Source 
Summary: As in title. I don't think there's a good reason to have this, better to have the caller be explicit.

Reviewed By: afrind, hanidamlaj

Differential Revision: D45875589

fbshipit-source-id: 3958ca10db542923b46ed8511c996ab3b292e9ab
This commit is contained in:
Matt Joras
2023-05-16 12:22:41 -07:00
committed by Facebook GitHub Bot
parent 9c51dd3ac8
commit 89cb636283
3 changed files with 26 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
quic/api/test/QuicPacketSchedulerTest.cpp
View File

@ -1217,7 +1217,10 @@ TEST_F(QuicPacketSchedulerTest, StreamFrameSchedulerAllFit) {
folly::IOBuf::copyBuffer("some data"),
false);
scheduler.writeStreams(builder);
EXPECT_EQ(conn.streamManager->writableStreams().getNextScheduledStream(), 0);
EXPECT_EQ(
conn.streamManager->writableStreams().getNextScheduledStream(
kDefaultPriority),
0);
}
TEST_F(QuicPacketSchedulerTest, StreamFrameSchedulerRoundRobin) {
@ -1262,7 +1265,10 @@ TEST_F(QuicPacketSchedulerTest, StreamFrameSchedulerRoundRobin) {
false);
// Force the wraparound initially.
scheduler.writeStreams(builder);
EXPECT_EQ(conn.streamManager->writableStreams().getNextScheduledStream(), 4);
EXPECT_EQ(
conn.streamManager->writableStreams().getNextScheduledStream(
kDefaultPriority),
4);
// Should write frames for stream2, stream3, followed by stream1 again.
NiceMock<MockQuicPacketBuilder> builder2;
@ -1327,7 +1333,9 @@ TEST_F(QuicPacketSchedulerTest, StreamFrameSchedulerRoundRobinStreamPerPacket) {
// The default is to wraparound initially.
scheduler.writeStreams(builder1);
EXPECT_EQ(
conn.streamManager->writableStreams().getNextScheduledStream(), stream2);
conn.streamManager->writableStreams().getNextScheduledStream(
kDefaultPriority),
stream2);
// Should write frames for stream2, stream3, followed by stream1 again.
NiceMock<MockQuicPacketBuilder> builder2;
@ -1475,7 +1483,9 @@ TEST_F(QuicPacketSchedulerTest, StreamFrameSchedulerRoundRobinControl) {
// The default is to wraparound initially.
scheduler.writeStreams(builder);
EXPECT_EQ(
conn.streamManager->writableStreams().getNextScheduledStream(), stream3);
conn.streamManager->writableStreams().getNextScheduledStream(
kDefaultPriority),
stream3);
EXPECT_EQ(conn.schedulingState.nextScheduledControlStream, stream2);
// Should write frames for stream2, stream4, followed by stream 3 then 1.
@ -1501,7 +1511,9 @@ TEST_F(QuicPacketSchedulerTest, StreamFrameSchedulerRoundRobinControl) {
EXPECT_EQ(*frames[3].asWriteStreamFrame(), f4);
EXPECT_EQ(
conn.streamManager->writableStreams().getNextScheduledStream(), stream3);
conn.streamManager->writableStreams().getNextScheduledStream(
kDefaultPriority),
stream3);
EXPECT_EQ(conn.schedulingState.nextScheduledControlStream, stream2);
}
@ -1525,7 +1537,10 @@ TEST_F(QuicPacketSchedulerTest, StreamFrameSchedulerOneStream) {
auto stream1 = conn.streamManager->createNextBidirectionalStream().value();
writeDataToQuicStream(*stream1, folly::IOBuf::copyBuffer("some data"), false);
scheduler.writeStreams(builder);
EXPECT_EQ(conn.streamManager->writableStreams().getNextScheduledStream(), 0);
EXPECT_EQ(
conn.streamManager->writableStreams().getNextScheduledStream(
kDefaultPriority),
0);
}
TEST_F(QuicPacketSchedulerTest, StreamFrameSchedulerRemoveOne) {