lib/mvfst
1
0
Fork 0
mirror of https://github.com/facebookincubator/mvfst.git synced 2025-11-09 10:00:57 +03:00
Code Activity

Make OutstandingPacketMetadata::DetailsPerStream non-optional

Browse Source 
Summary: As titled. Reduces confusion, as we always expect this to be populated.

Differential Revision: D31887097

fbshipit-source-id: 153b05bae8abd559fe49d2c07c64d2ad0d92a809
This commit is contained in:
Brandon Schlinker
2021-12-11 22:39:07 -08:00
committed by Facebook GitHub Bot
parent 7233c55d29
commit 82fd138b5e
12 changed files with 219 additions and 98 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
quic/state/test/QuicStateFunctionsTest.cpp
View File

@@ -8,6 +8,7 @@
#include <gmock/gmock.h>
#include <gtest/gtest.h>
#include "quic/state/OutstandingPacket.h"
#include <quic/common/test/TestUtils.h>
#include <quic/fizz/server/handshake/FizzServerQuicHandshakeContext.h>
@@ -705,7 +706,8 @@ TEST_F(QuicStateFunctionsTest, GetOutstandingPackets) {
0,
0,
LossState(),
0);
0,
OutstandingPacketMetadata::DetailsPerStream());
conn.outstandings.packets.emplace_back(
makeTestLongPacket(LongHeader::Types::Handshake),
Clock::now(),
@@ -717,7 +719,8 @@ TEST_F(QuicStateFunctionsTest, GetOutstandingPackets) {
0,
0,
LossState(),
0);
0,
OutstandingPacketMetadata::DetailsPerStream());
conn.outstandings.packets.emplace_back(
makeTestShortPacket(),
Clock::now(),
@@ -729,7 +732,8 @@ TEST_F(QuicStateFunctionsTest, GetOutstandingPackets) {
0,
0,
LossState(),
0);
0,
OutstandingPacketMetadata::DetailsPerStream());
conn.outstandings.packets.emplace_back(
makeTestLongPacket(LongHeader::Types::Initial),
Clock::now(),
@@ -741,7 +745,8 @@ TEST_F(QuicStateFunctionsTest, GetOutstandingPackets) {
0,
0,
LossState(),
0);
0,
OutstandingPacketMetadata::DetailsPerStream());
conn.outstandings.packets.emplace_back(
makeTestShortPacket(),
Clock::now(),
@@ -753,7 +758,8 @@ TEST_F(QuicStateFunctionsTest, GetOutstandingPackets) {
0,
0,
LossState(),
0);
0,
OutstandingPacketMetadata::DetailsPerStream());
EXPECT_EQ(
135,
getFirstOutstandingPacket(conn, PacketNumberSpace::Initial)