1
0
mirror of https://github.com/facebookincubator/mvfst.git synced 2025-11-09 10:00:57 +03:00

log cwnd hint bytes to ODS

Reviewed By: jbeshay

Differential Revision: D50753856

fbshipit-source-id: 6e2aba9138f96b175ecb4a7667579ca4547eaa70
This commit is contained in:
Paul Farcasanu
2023-11-03 16:15:42 -07:00
committed by Facebook GitHub Bot
parent bbf48f1be6
commit 77b0940dc5
4 changed files with 8 additions and 2 deletions

View File

@@ -170,6 +170,10 @@ class LogQuicStats : public quic::QuicTransportStatsCallback {
VLOG(2) << __func__ << " bandwidth=" << bandwidth; VLOG(2) << __func__ << " bandwidth=" << bandwidth;
} }
void onCwndHintBytesSample(uint64_t cwndHintBytes) override {
VLOG(2) << __func__ << " cwndHintBytes=" << cwndHintBytes;
}
void onNewCongestionController(CongestionControlType type) override { void onNewCongestionController(CongestionControlType type) override {
VLOG(2) << prefix_ << __func__ VLOG(2) << prefix_ << __func__
<< " type=" << congestionControlTypeToString(type); << " type=" << congestionControlTypeToString(type);

View File

@@ -568,8 +568,7 @@ void updateTransportParamsFromTicket(
conn.maybeCwndHintBytes = maybeCwndHintBytes; conn.maybeCwndHintBytes = maybeCwndHintBytes;
if (maybeCwndHintBytes) { if (maybeCwndHintBytes) {
VLOG(7) << fmt::format( QUIC_STATS(conn.statsCallback, onCwndHintBytesSample, *maybeCwndHintBytes);
"Got a cwnd hint in a 0-rtt ticket. = {}", *maybeCwndHintBytes);
} }
} }

View File

@@ -115,6 +115,8 @@ class QuicTransportStatsCallback {
virtual void onBandwidthSample(uint64_t) = 0; virtual void onBandwidthSample(uint64_t) = 0;
virtual void onCwndHintBytesSample(uint64_t cwndHintBytes) = 0;
virtual void onNewCongestionController(CongestionControlType type) = 0; virtual void onNewCongestionController(CongestionControlType type) = 0;
// retransmission timeout counter // retransmission timeout counter

View File

@@ -49,6 +49,7 @@ class MockQuicStats : public QuicTransportStatsCallback {
MOCK_METHOD(void, onInflightBytesSample, (uint64_t)); MOCK_METHOD(void, onInflightBytesSample, (uint64_t));
MOCK_METHOD(void, onRttSample, (uint64_t)); MOCK_METHOD(void, onRttSample, (uint64_t));
MOCK_METHOD(void, onBandwidthSample, (uint64_t)); MOCK_METHOD(void, onBandwidthSample, (uint64_t));
MOCK_METHOD(void, onCwndHintBytesSample, (uint64_t));
MOCK_METHOD(void, onNewCongestionController, (CongestionControlType)); MOCK_METHOD(void, onNewCongestionController, (CongestionControlType));
MOCK_METHOD(void, onPTO, ()); MOCK_METHOD(void, onPTO, ());
MOCK_METHOD(void, onRead, (size_t)); MOCK_METHOD(void, onRead, (size_t));