diff --git a/quic/codec/test/Mocks.h b/quic/codec/test/Mocks.h index 7b9509a43..980c02c6c 100644 --- a/quic/codec/test/Mocks.h +++ b/quic/codec/test/Mocks.h @@ -23,9 +23,9 @@ std::ostream& operator<<(std::ostream& out, const QuicWriteFrame& /*rhs*/) { namespace quic { namespace test { -class MockConnectoinIdAlgo : public ConnectionIdAlgo { +class MockConnectionIdAlgo : public ConnectionIdAlgo { public: - GMOCK_METHOD1_(, const noexcept, , canParse, bool(const ConnectionId& id)); + GMOCK_METHOD1_(, noexcept, , canParseNonConst, bool(const ConnectionId& id)); GMOCK_METHOD1_( , noexcept, @@ -40,6 +40,10 @@ class MockConnectoinIdAlgo : public ConnectionIdAlgo { encodeConnectionId, folly::Expected( const ServerConnectionIdParams&)); + + bool canParse(const ConnectionId& id) const noexcept override { + return const_cast(*this).canParseNonConst(id); + } }; class MockQuicPacketBuilder : public PacketBuilderInterface { diff --git a/quic/server/test/QuicServerTest.cpp b/quic/server/test/QuicServerTest.cpp index 0c8096b28..23be2f4c2 100644 --- a/quic/server/test/QuicServerTest.cpp +++ b/quic/server/test/QuicServerTest.cpp @@ -633,7 +633,7 @@ TEST_F(QuicServerWorkerTest, FailToParseConnectionId) { auto data = createData(kDefaultUDPSendPacketLen); auto srcConnId = getTestConnectionId(0); auto dstConnId = getTestConnectionId(1); - auto mockConnIdAlgo = std::make_unique(); + auto mockConnIdAlgo = std::make_unique(); auto rawConnIdAlgo = mockConnIdAlgo.get(); worker_->setConnectionIdAlgo(std::move(mockConnIdAlgo)); @@ -656,7 +656,7 @@ TEST_F(QuicServerWorkerTest, FailToParseConnectionId) { srcConnId); NetworkData networkData(std::move(packet), Clock::now()); - EXPECT_CALL(*rawConnIdAlgo, canParse(_)).WillOnce(Return(true)); + EXPECT_CALL(*rawConnIdAlgo, canParseNonConst(_)).WillOnce(Return(true)); EXPECT_CALL(*rawConnIdAlgo, parseConnectionId(dstConnId)) .WillOnce(Return(folly::makeUnexpected(QuicInternalException( "This CID has COVID-19", LocalErrorCode::INTERNAL_ERROR))));