lib/mvfst
1
0
Fork 0
mirror of https://github.com/facebookincubator/mvfst.git synced 2025-11-27 03:41:14 +03:00
Code Activity

Reset is a unidirectional event

Browse Source 
Summary:
Sending a reset shouldn't affect read states. Receiving a reset
shouldn't affect send states.

Reviewed By: afrind

Differential Revision: D15578287

fbshipit-source-id: 65c5e30666fd9e4c295317ba4c3e0653edbb78ff
This commit is contained in:
Yang Chi
2019-05-31 13:23:35 -07:00
committed by Facebook Github Bot
parent fc0c10c830
commit 75ab1ce6d5
6 changed files with 44 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
quic/codec/QuicPacketRebuilder.cpp
View File

@@ -84,10 +84,10 @@ folly::Optional<PacketEvent> PacketRebuilder::rebuildFromPacket(
notPureAck |= ret;
return ret;
}
// If a stream is already Closed, or HalfClosedLocal, we should not
// clone and resend this stream data. But should we abort the cloning
// of this packet and move on to the next packet? I'm gonna err on the
// aggressive side for now and call it success.
// If a stream is already Closed, we should not clone and resend this
// stream data. But should we abort the cloning of this packet and
// move on to the next packet? I'm gonna err on the aggressive side
// for now and call it success.
return true;
},
[&](const WriteCryptoFrame& cryptoFrame) {