lib/mvfst
1
0
Fork 0
mirror of https://github.com/facebookincubator/mvfst.git synced 2025-07-29 03:41:11 +03:00
Code Activity

Rename PacketEvent -> ClonedPacketIdentifier

Browse Source 
Summary: `PacketEvent` is a very inaccurate and misleading name. We're basically using this as an identifier for cloned packets, so `ClonedPacketIdentifier` is a much better.

Reviewed By: kvtsoy

Differential Revision: D61871891

fbshipit-source-id: f9c626d900c8b7ab7e231c9bad4c1629384ebb77
This commit is contained in:
Aman Sharma
2024-08-28 14:26:30 -07:00
committed by Facebook GitHub Bot
parent b63ca46293
commit 6f13f404b0
29 changed files with 349 additions and 279 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
quic/api/QuicPacketScheduler.cpp
View File

@ -924,9 +924,9 @@ SchedulingResult CloningScheduler::scheduleFramesForPacket(
}
// If the packet is already a clone that has been processed, we don't clone
// it again.
if (outstandingPacket.associatedEvent &&
conn_.outstandings.packetEvents.count(
*outstandingPacket.associatedEvent) == 0) {
if (outstandingPacket.maybeClonedPacketIdentifier &&
conn_.outstandings.clonedPacketIdentifiers.count(
*outstandingPacket.maybeClonedPacketIdentifier) == 0) {
continue;
}
// I think this only fail if udpSendPacketLen somehow shrinks in the middle