lib/mvfst
1
0
Fork 0
mirror of https://github.com/facebookincubator/mvfst.git synced 2025-08-06 22:22:38 +03:00
Code Activity

elide malloc calls

Browse Source 
Summary: - optimizing `setSupportedExtensionTransportParameters()` to elide invocations to malloc()

Reviewed By: mjoras

Differential Revision: D43844018

fbshipit-source-id: 38da5c62786f795a3a79e7592d06d4da1d7487ba
This commit is contained in:
Hani Damlaj
2023-03-15 15:58:02 -07:00
committed by Facebook GitHub Bot
parent 3452070d5c
commit 6cd4f47735
9 changed files with 94 additions and 115 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
quic/api/test/QuicTransportFunctionsTest.cpp
View File

@@ -4535,28 +4535,26 @@ TEST_F(QuicTransportFunctionsTest, CustomTransportParamTest) {
// Add new param.
EXPECT_TRUE(setCustomTransportParameter(
std::make_unique<CustomIntegralTransportParameter>(
kCustomTransportParameterThreshold, 0),
CustomIntegralTransportParameter(kCustomTransportParameterThreshold, 0),
customTransportParameters));
EXPECT_EQ(customTransportParameters.size(), 1);
// Existing param not added.
EXPECT_FALSE(setCustomTransportParameter(
std::make_unique<CustomIntegralTransportParameter>(
kCustomTransportParameterThreshold, 1),
CustomIntegralTransportParameter(kCustomTransportParameterThreshold, 1),
customTransportParameters));
EXPECT_EQ(customTransportParameters.size(), 1);
// Bad param id is not added.
EXPECT_FALSE(setCustomTransportParameter(
std::make_unique<CustomIntegralTransportParameter>(
CustomIntegralTransportParameter(
kCustomTransportParameterThreshold - 1, 2),
customTransportParameters));
EXPECT_EQ(customTransportParameters.size(), 1);
// Another valid param added.
EXPECT_TRUE(setCustomTransportParameter(
std::make_unique<CustomIntegralTransportParameter>(
CustomIntegralTransportParameter(
kCustomTransportParameterThreshold + 1, 0),
customTransportParameters));
EXPECT_EQ(customTransportParameters.size(), 2);