lib/mvfst
1
0
Fork 0
mirror of https://github.com/facebookincubator/mvfst.git synced 2025-11-24 04:01:07 +03:00
Code Activity

consolidate setSupportedExtensionTransportParameters

Browse Source 
Summary: - remove duplicated function `setSupportedExtensionTransportParameters` in QuicClient & QuicServer

Reviewed By: jbeshay

Differential Revision: D50933970

fbshipit-source-id: f5ae1a9739d316165a5759c68076ec2152f641c6
This commit is contained in:
Hani Damlaj
2023-12-03 22:26:40 -08:00
committed by Facebook GitHub Bot
parent 229a91cb9d
commit 6a3fd0b7f2
7 changed files with 60 additions and 101 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
quic/server/test/ServerStateMachineTest.cpp
View File

@@ -270,8 +270,7 @@ TEST(ServerStateMachineTest, TestEncodeMinAckDelayParamSet) {
QuicServerConnectionState serverConn(
FizzServerQuicHandshakeContext::Builder().build());
serverConn.transportSettings.minAckDelay = std::chrono::microseconds(1000);
auto customTransportParams =
quic::setSupportedExtensionTransportParameters(serverConn);
auto customTransportParams = getSupportedExtTransportParams(serverConn);
auto minAckDelayParam = getIntegerParameter(
TransportParameterId::min_ack_delay, customTransportParams);
ASSERT_TRUE(minAckDelayParam.has_value());
@@ -282,8 +281,7 @@ TEST(ServerStateMachineTest, TestEncodeMinAckDelayParamNotSet) {
QuicServerConnectionState serverConn(
FizzServerQuicHandshakeContext::Builder().build());
serverConn.transportSettings.advertisedKnobFrameSupport = false;
auto customTransportParams =
quic::setSupportedExtensionTransportParameters(serverConn);
auto customTransportParams = getSupportedExtTransportParams(serverConn);
EXPECT_THAT(
customTransportParams,
Not(Contains(testing::Field(
@@ -319,8 +317,7 @@ TEST(ServerStateMachineTest, TestEncodeKnobFrameSupportedParamEnabled) {
QuicServerConnectionState serverConn(
FizzServerQuicHandshakeContext::Builder().build());
serverConn.transportSettings.advertisedKnobFrameSupport = true;
auto customTransportParams =
quic::setSupportedExtensionTransportParameters(serverConn);
auto customTransportParams = getSupportedExtTransportParams(serverConn);
auto knobFrameSupportedParam = getIntegerParameter(
TransportParameterId::knob_frames_supported, customTransportParams);
ASSERT_TRUE(knobFrameSupportedParam.has_value());
@@ -331,8 +328,7 @@ TEST(ServerStateMachineTest, TestEncodeKnobFrameSupportedParamDisabled) {
QuicServerConnectionState serverConn(
FizzServerQuicHandshakeContext::Builder().build());
serverConn.transportSettings.advertisedKnobFrameSupport = false;
auto customTransportParams =
quic::setSupportedExtensionTransportParameters(serverConn);
auto customTransportParams = getSupportedExtTransportParams(serverConn);
EXPECT_THAT(
customTransportParams,
Not(Contains(testing::Field(