lib/mvfst
1
0
Fork 0
mirror of https://github.com/facebookincubator/mvfst.git synced 2025-11-24 04:01:07 +03:00
Code Activity

Accept session tickets with additional optional parameters

Browse Source 
Summary:
Allow server to accept session tickets with additional paramters that won't be used.

A subset of servers can include additional transport parameters in the session ticket that are only useful to them. This allows other servers to still use the ticket as long as it has the fields they expect, ignoring any additional parameters.

Reviewed By: mjoras

Differential Revision: D43131800

fbshipit-source-id: ff4ea503c2e30b9bd0e1caf77b418c3891ffdd7f
This commit is contained in:
Joseph Beshay
2023-02-23 17:16:07 -08:00
committed by Facebook GitHub Bot
parent ccde77f256
commit 62d4ef978a
4 changed files with 42 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
quic/server/handshake/test/DefaultAppTokenValidatorTest.cpp
View File

@@ -57,6 +57,39 @@ TEST(DefaultAppTokenValidatorTest, TestValidParams) {
EXPECT_TRUE(validator.validate(resState));
}
TEST(DefaultAppTokenValidatorTest, TestValidOptionalParameter) {
QuicServerConnectionState conn(
FizzServerQuicHandshakeContext::Builder().build());
conn.peerAddress = folly::SocketAddress("1.2.3.4", 443);
conn.version = QuicVersion::MVFST;
conn.transportSettings.zeroRttSourceTokenMatchingPolicy =
ZeroRttSourceTokenMatchingPolicy::LIMIT_IF_NO_EXACT_MATCH;
auto quicStats = std::make_shared<MockQuicStats>();
conn.statsCallback = quicStats.get();
AppToken appToken;
appToken.transportParams = createTicketTransportParameters(
conn.transportSettings.idleTimeout.count(),
conn.transportSettings.maxRecvPacketSize,
conn.transportSettings.advertisedInitialConnectionWindowSize,
conn.transportSettings.advertisedInitialBidiLocalStreamWindowSize,
conn.transportSettings.advertisedInitialBidiRemoteStreamWindowSize,
conn.transportSettings.advertisedInitialUniStreamWindowSize,
conn.transportSettings.advertisedInitialMaxStreamsBidi,
conn.transportSettings.advertisedInitialMaxStreamsUni);
appToken.transportParams.parameters.push_back(
encodeIntegerParameter(TransportParameterId::disable_migration, 1));
ResumptionState resState;
resState.appToken = encodeAppToken(appToken);
conn.earlyDataAppParamsValidator = [](const folly::Optional<std::string>&,
const Buf&) { return true; };
DefaultAppTokenValidator validator(&conn);
EXPECT_CALL(*quicStats, onZeroRttAccepted()).Times(1);
EXPECT_CALL(*quicStats, onZeroRttRejected()).Times(0);
EXPECT_TRUE(validator.validate(resState));
}
TEST(
DefaultAppTokenValidatorTest,
TestValidUnequalParamsUpdateTransportSettings) {