lib/mvfst
1
0
Fork 0
mirror of https://github.com/facebookincubator/mvfst.git synced 2025-08-08 09:42:06 +03:00
Code Activity

Stop setting clientConnId in ServerStateMachine [2/x]

Browse Source 
Summary:
Removes clientConnId completely from ServerConnectionIdParams.

This diff first fixes an incorrect assumption; it calls
`shortHeader.getConnectionId()` which is actually the destination id (server)
not the client connection id.

Next, this entire block is unnecessary, because this will be called after
the transport is created, so the clientConnectionId will always be set.

This also setsconn.serverConnectionId earlier (shouldn't depend on
connClientId).

Reviewed By: yangchi

Differential Revision: D16792866

fbshipit-source-id: 537ba12baa9939c9d5512e46eb914c1d3a7a9aa2
This commit is contained in:
Viktor Chynarov
2019-08-23 15:03:10 -07:00
committed by Facebook Github Bot
parent 196dd99308
commit 594a98be7a
8 changed files with 4 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
quic/api/test/QuicTransportBaseTest.cpp
View File

@@ -163,7 +163,6 @@ class TestQuicTransport
while (!cursor.isAtEnd()) {
// create server chosen connId with processId = 0 and workerId = 0
ServerConnectionIdParams params(0, 0, 0);
params.clientConnId = *conn_->clientConnectionId;
conn_->serverConnectionId = connIdAlgo_->encodeConnectionId(params);
auto type = static_cast<TestFrameType>(cursor.readBE<uint8_t>());
if (type == TestFrameType::CRYPTO) {
@@ -312,7 +311,6 @@ class TestQuicTransport
void setServerConnectionId() {
// create server chosen connId with processId = 0 and workerId = 0
ServerConnectionIdParams params(0, 0, 0);
params.clientConnId = *conn_->clientConnectionId;
conn_->serverConnectionId = connIdAlgo_->encodeConnectionId(params);
}