lib/mvfst
1
0
Fork 0
mirror of https://github.com/facebookincubator/mvfst.git synced 2025-11-10 21:22:20 +03:00
Code Activity

Remove a few quic traces

Browse Source 
Summary:
Remove all the stream events, packet/udp recv event and ack event.
They are >40%  of  the  events.

Reviewed By: mjoras

Differential Revision: D19466165

fbshipit-source-id: 3a20b201e630527e6d25d1a14f0f520728190d50
This commit is contained in:
Yang Chi
2020-01-29 17:08:47 -08:00
committed by Facebook Github Bot
parent 46e9228420
commit 591f27c6f1
3 changed files with 0 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
quic/client/QuicClientTransport.cpp
View File

@@ -248,7 +248,6 @@ void QuicClientTransport::processPacketData(
} }
} }
} }
QUIC_TRACE(packet_recvd, *conn_, toString(pnSpace), packetNum, packetSize);
// We got a packet that was not the version negotiation packet, that means // We got a packet that was not the version negotiation packet, that means
// that the version is now bound to the new packet. // that the version is now bound to the new packet.
@@ -1051,7 +1050,6 @@ void QuicClientTransport::onDataAvailable(
return; return;
} }
data->append(len); data->append(len);
QUIC_TRACE(udp_recvd, *conn_, (uint64_t)len);
if (conn_->qLogger) { if (conn_->qLogger) {
conn_->qLogger->addDatagramReceived(len); conn_->qLogger->addDatagramReceived(len);
} }
@@ -1118,7 +1116,6 @@ void QuicClientTransport::recvMsg(
VLOG(10) << "Got data from socket peer=" << *server << " len=" << bytesRead; VLOG(10) << "Got data from socket peer=" << *server << " len=" << bytesRead;
readBuffer->append(bytesRead); readBuffer->append(bytesRead);
networkData.packets.emplace_back(std::move(readBuffer)); networkData.packets.emplace_back(std::move(readBuffer));
QUIC_TRACE(udp_recvd, *conn_, bytesRead);
if (conn_->qLogger) { if (conn_->qLogger) {
conn_->qLogger->addDatagramReceived(bytesRead); conn_->qLogger->addDatagramReceived(bytesRead);
} }

2
quic/server/state/ServerStateMachine.cpp
View File

@@ -701,7 +701,6 @@ void onServerReadDataFromOpen(
conn.qLogger->dcid = conn.clientConnectionId; conn.qLogger->dcid = conn.clientConnectionId;
conn.qLogger->scid = conn.serverConnectionId; conn.qLogger->scid = conn.serverConnectionId;
} }
QUIC_TRACE(packet_recvd, conn, packetNum, packetSize);
// We assume that the higher layer takes care of validating that the version // We assume that the higher layer takes care of validating that the version
// is supported. // is supported.
if (!conn.version) { if (!conn.version) {
@@ -1130,7 +1129,6 @@ void onServerReadDataFromClosed(
if (conn.qLogger) { if (conn.qLogger) {
conn.qLogger->addPacket(regularPacket, packetSize); conn.qLogger->addPacket(regularPacket, packetSize);
} }
QUIC_TRACE(packet_recvd, conn, packetNum, packetSize);
// Only process the close frames in the packet // Only process the close frames in the packet
for (auto& quicFrame : regularPacket.frames) { for (auto& quicFrame : regularPacket.frames) {

3
quic/state/AckHandlers.cpp
View File

@@ -186,9 +186,6 @@ void processAckFrame(
updatedOustandingPacketsCount, conn.outstandingHandshakePacketsCount); updatedOustandingPacketsCount, conn.outstandingHandshakePacketsCount);
DCHECK_GE(updatedOustandingPacketsCount, conn.outstandingClonedPacketsCount); DCHECK_GE(updatedOustandingPacketsCount, conn.outstandingClonedPacketsCount);
auto lossEvent = handleAckForLoss(conn, lossVisitor, ack, pnSpace); auto lossEvent = handleAckForLoss(conn, lossVisitor, ack, pnSpace);
if (ack.largestAckedPacket.hasValue()) {
QUIC_TRACE(packets_acked, conn, ack.ackedBytes);
}
if (conn.congestionController && if (conn.congestionController &&
(ack.largestAckedPacket.hasValue() || lossEvent)) { (ack.largestAckedPacket.hasValue() || lossEvent)) {
if (lossEvent) { if (lossEvent) {