lib/mvfst
1
0
Fork 0
mirror of https://github.com/facebookincubator/mvfst.git synced 2025-11-24 04:01:07 +03:00
Code Activity

Fix missed cases in QuicInteger -> Expected change

Browse Source 
Summary:
These cases were missed due to the fact that writeFrame was returning something different.

Also, revert the change in the codec for receive timestamps that was using value_or and suppressing something too large being encoded.

Reviewed By: jbeshay, kvtsoy

Differential Revision: D72904909

fbshipit-source-id: 47e415e7b12208c8a2917325ed42f51c63992687
This commit is contained in:
Matt Joras
2025-04-11 22:09:59 -07:00
committed by Facebook GitHub Bot
parent d14872347d
commit 58d7c06951
4 changed files with 57 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
quic/codec/QuicWriteCodec.cpp
View File

@@ -601,22 +601,13 @@ computeReceiveTimestampsMinimumSpace(
}
auto countRangesSize = getQuicIntegerSize(countTimestampRanges);
if (countRangesSize.hasError()) {
return folly::makeUnexpected(countRangesSize.error());
}
auto lastPktNumSize = getQuicIntegerSize(maybeLastPktNum);
if (lastPktNumSize.hasError()) {
return folly::makeUnexpected(lastPktNumSize.error());
}
auto lastPktTsDeltaSize = getQuicIntegerSize(maybeLastPktTsDelta.count());
if (lastPktTsDeltaSize.hasError()) {
return folly::makeUnexpected(lastPktTsDeltaSize.error());
}
return countRangesSize.value() + lastPktNumSize.value() +
lastPktTsDeltaSize.value();
return countRangesSize.value_or(0) + lastPktNumSize.value_or(0) +
lastPktTsDeltaSize.value_or(0);
}
static void writeECNFieldsToAck(