lib/mvfst
1
0
Fork 0
mirror of https://github.com/facebookincubator/mvfst.git synced 2025-08-06 22:22:38 +03:00
Code Activity

Fix missed cases in QuicInteger -> Expected change

Browse Source 
Summary:
These cases were missed due to the fact that writeFrame was returning something different.

Also, revert the change in the codec for receive timestamps that was using value_or and suppressing something too large being encoded.

Reviewed By: jbeshay, kvtsoy

Differential Revision: D72904909

fbshipit-source-id: 47e415e7b12208c8a2917325ed42f51c63992687
This commit is contained in:
Matt Joras
2025-04-11 22:09:59 -07:00
committed by Facebook GitHub Bot
parent d14872347d
commit 58d7c06951
4 changed files with 57 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
quic/api/test/QuicPacketSchedulerTest.cpp
View File

@@ -560,7 +560,7 @@ TEST_F(QuicPacketSchedulerTest, StreamFrameSchedulerExists) {
ASSERT_FALSE(builder.encodePacketHeader().hasError());
auto originalSpace = builder.remainingSpaceInPkt();
conn.streamManager->queueWindowUpdate(stream->id);
scheduler.writeWindowUpdates(builder);
ASSERT_FALSE(scheduler.writeWindowUpdates(builder).hasError());
EXPECT_LT(builder.remainingSpaceInPkt(), originalSpace);
}
@@ -585,7 +585,7 @@ TEST_F(QuicPacketSchedulerTest, StreamFrameNoSpace) {
PacketBuilderWrapper builderWrapper(builder, 2);
auto originalSpace = builder.remainingSpaceInPkt();
conn.streamManager->queueWindowUpdate(stream->id);
scheduler.writeWindowUpdates(builderWrapper);
ASSERT_FALSE(scheduler.writeWindowUpdates(builderWrapper).hasError());
EXPECT_EQ(builder.remainingSpaceInPkt(), originalSpace);
}
@@ -607,7 +607,7 @@ TEST_F(QuicPacketSchedulerTest, StreamFrameSchedulerStreamNotExists) {
ASSERT_FALSE(builder.encodePacketHeader().hasError());
auto originalSpace = builder.remainingSpaceInPkt();
conn.streamManager->queueWindowUpdate(nonExistentStream);
scheduler.writeWindowUpdates(builder);
ASSERT_FALSE(scheduler.writeWindowUpdates(builder).hasError());
EXPECT_EQ(builder.remainingSpaceInPkt(), originalSpace);
}